Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acyclic to 0.3.16 #1598

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates com.lihaoyi:acyclic from 0.3.15 to 0.3.16

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "acyclic" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi", artifactId = "acyclic" }
}]
labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

@lefou
Copy link
Member

lefou commented Jan 14, 2025

Change look good, but CI fail. Don't know why.

@Jasper-M
Copy link

Could it be that the acyclic upgrade and scala 2.13.16 upgrade have to happen in one atomic change?

@lefou
Copy link
Member

lefou commented Jan 17, 2025

Could it be that the acyclic upgrade and scala 2.13.16 upgrade have to happen in one atomic change?

No. Acyclic is a compiler plugin which needs to support the target compiler, so updating acyclic is a prerequisite to updating Scala.

The CI issues could be unrelated to this bump (there are same looking issues in other CI runs), but as an occasional maintainer, I don't feel confident enough to just press the merge button.

@lihaoyi lihaoyi merged commit 5f662a2 into com-lihaoyi:main Jan 21, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants