-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* add LoadImageOutput node * add route for input/output/temp files * update node_typing.py * use literal type for image_folder field * mark node as beta
- Loading branch information
1 parent
acc152b
commit afc85cd
Showing
3 changed files
with
69 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc85cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are image_upload and image_folder still retained in the COMBO type? This seems to have no direct connection with the COMBO type, and it appears they are coupled together. Is this for maintaining compatibility?
afc85cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to the types only? The
image_upload
andimage_folder
tell the frontend to turn the node into a node that can upload images (via combo value selection, drag-and-drop, copy-paste, and file upload button). The assumption is that the value of the input corresponds to a valid filename in the given folder. They could be applied to STRING inputs as well but it's just not supported currently.Or are you just suggesting they be moved into a nested dict? In that case I would agree with you but
image_upload
has already existed for a long time.afc85cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation. I have learned about the historical background.