Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Car Port: Subaru Ascent 2023 #1234

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

bravochar
Copy link

@bravochar bravochar commented Sep 11, 2024

2023 Subaru Ascent

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/opcar/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: '3d0a2ec61b4035d3|00000012--f60c832c46'
  • route with stock system: "99437cef6d5ff2ee|2023-03-13--21-21-38" (It was like that when I got here)
  • car harness used (if comma doesn't sell it, put N/A): Subaru D

Panda PR (tests won't pass without this): commaai/panda#2020

@github-actions github-actions bot added car related to opendbc/car/ subaru fingerprint labels Sep 11, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

Mentioned in @martinl PR, and it seems these are no longer queries/returned in my vehicle
@bravochar bravochar marked this pull request as draft September 11, 2024 13:56
@bravochar
Copy link
Author

Moved to draft since #1193 supercedes this.

@bravochar bravochar changed the title Fingerprint: Subaru Ascent 2023 WIP: Car Port: Subaru Ascent 2023 Sep 14, 2024
@bravochar
Copy link
Author

Had a successful drive today, though the steering inputs were a bit jerky. I'm going to wait to add my openpilot route until the Panda PR gets approved (pending feedback of course), and I take the time to tune the experience to be a little smoother.

@martinl
Copy link
Contributor

martinl commented Sep 14, 2024

Please share the route if you can, I think it will make reviewing and verifying things easier

@bravochar
Copy link
Author

Uploading a route with Openpilot running presently (see above). I didn't do anything special, but it's running and doing lateral fairly well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint subaru
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants