HKG: Car Port for Hyundai Palisade and Kia Telluride 2023-24 (non-HDA2) #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyhaibin
force-pushed
the
palisade-2023-port-2-new
branch
from
4d68e0f
to
d68fdc4
Compare
jyoung8607
requested changes
Sep 29, 2024
There was a problem hiding this comment.
I think this one could use some preparatory refactors (in separate PRs) before going forward.
- The CanBus class should move from hyundaicanfd to values, and then just switch to always using that for bus selection on all cars, getting rid of a lot of extra conditional branches.
- The CAN packer functions should gain a bus argument and the bus should be passed down from carcontroller. This will allow a lot of cleanup, especially the duplicate lkas11 packer.
I can help with some of the refactors later.
| @@ -113,11 +113,12 @@ def update(self, cp, cp_cam, *_) -> structs.CarState: | |||
| ret.cruiseState.standstill = False | |||
| ret.cruiseState.nonAdaptive = False | |||
| else: | |||
| ret.cruiseState.available = cp_cruise.vl["SCC11"]["MainMode_ACC"] == 1 | |||
| scc_bus = "SCC12" if self.CP.flags & HyundaiFlags.CAN_CANFD_HYBRID else "SCC11" | |||
There was a problem hiding this comment.
scc_bus is a misnomer, it's really scc_msg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes
Requires