Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy ascendant calculation #38

Closed
wants to merge 6 commits into from
Closed

Conversation

TheMascot
Copy link

Dear @commenthol!

As my connecting issue states,
#37
I wrote a function to calculate the ascendant based on the observer's location on Earth and the exact time. Furthermore a basic location format converter for easier use.
Added a test file too in the test folder and npm test runs green.

I would be honored to contribute to your library.

@TheMascot
Copy link
Author

I forgot to deal with the local time difference that is created using the new Date() constructor in JavaScript in different timezones. I thought this through several times in the past days and pretty sure this causes the problem. Have to convert to UTC than work with that. I plan on fixing it this week. Sorry for the buggy pull request.

@TheMascot TheMascot closed this Oct 11, 2024
@TheMascot
Copy link
Author

TheMascot commented Oct 11, 2024

I tested my theory and npm test returns with errors if I modify the timezone in the OS from my original one.
However I tested with separate astrology charting programs, modifying the place of birth and the timezone in the OS, the output ascendant degree is correct. So the code is ok. The test has to be modified to represent always the exact time of the given coordinates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant