-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated sdk version to 17.4 #33
base: solutions
Are you sure you want to change the base?
Conversation
I made of lot of changes but I am not sure if all of them are acceptable in the master branch. Please, share your thoughts and I will update the master branch accordingly. Major changes are:
|
final String password, | ||
final String anonymousCartId, | ||
final AnonymousCartSignInMode anonymousCartSignInMode) { | ||
CustomerSignin customerSignin = CustomerSigninBuilder.of() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CustomerSignin customerSignin = CustomerSigninBuilder.of() | |
CustomerSignin customerSignin = CustomerSignin.builder() |
CustomerSignin customerSignin = CustomerSigninBuilder.of() | ||
.email(customerEmail) | ||
.password(password) | ||
.anonymousCart(CartResourceIdentifierBuilder.of() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.anonymousCart(CartResourceIdentifierBuilder.of() | |
.anonymousCart(CartResourceIdentifier.builder() |
.addresses( | ||
AddressBuilder.of() | ||
.key(customerKey + "-default-address") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.addresses( | |
AddressBuilder.of() | |
.key(customerKey + "-default-address") | |
.addresses( | |
AddressDraft.builder() | |
.key(customerKey + "-default-address") |
or
.addresses( | |
AddressBuilder.of() | |
.key(customerKey + "-default-address") | |
.plusAddresses( | |
addressBuilder -> addressBuilder | |
.key(customerKey + "-default-address") |
This PR is missing a Jira ticket reference in the title or description. |
🥷 Code experts: jenschude jenschude has most 🧠 knowledge in the files. See details
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
No description provided.