Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated sdk version to 17.4 #33

Open
wants to merge 25 commits into
base: solutions
Choose a base branch
from

Conversation

nagesh-dixit
Copy link
Contributor

No description provided.

@nagesh-dixit
Copy link
Contributor Author

I made of lot of changes but I am not sure if all of them are acceptable in the master branch. Please, share your thoughts and I will update the master branch accordingly. Major changes are:

  1. Updated version to 17.5
  2. Using Lambdas more
  3. Exceptionally in most calls
  4. Replaced RetryMiddleware with withPolicies because it's deprecated
  5. Using channelKey instead of Channel object in Checkout tasks
  6. Adding and displaying items in the Merge task
  7. Separated ME and Stores tasks.
  8. Added expectation that ProductSelection be created and products added in the MC before running the task to add the ProductSelection to the Store.

final String password,
final String anonymousCartId,
final AnonymousCartSignInMode anonymousCartSignInMode) {
CustomerSignin customerSignin = CustomerSigninBuilder.of()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CustomerSignin customerSignin = CustomerSigninBuilder.of()
CustomerSignin customerSignin = CustomerSignin.builder()

CustomerSignin customerSignin = CustomerSigninBuilder.of()
.email(customerEmail)
.password(password)
.anonymousCart(CartResourceIdentifierBuilder.of()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.anonymousCart(CartResourceIdentifierBuilder.of()
.anonymousCart(CartResourceIdentifier.builder()

Comment on lines +55 to +57
.addresses(
AddressBuilder.of()
.key(customerKey + "-default-address")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.addresses(
AddressBuilder.of()
.key(customerKey + "-default-address")
.addresses(
AddressDraft.builder()
.key(customerKey + "-default-address")

or

Suggested change
.addresses(
AddressBuilder.of()
.key(customerKey + "-default-address")
.plusAddresses(
addressBuilder -> addressBuilder
.key(customerKey + "-default-address")

Copy link

gitstream-cm bot commented Jun 10, 2024

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

Copy link

gitstream-cm bot commented Jun 10, 2024

🥷 Code experts: jenschude

jenschude has most 🧠 knowledge in the files.

See details

build.gradle

Knowledge based on git-blame:
jenschude: 8%

src/main/java/handson/Task02a_CREATE.java

Knowledge based on git-blame:
jenschude: 52%

src/main/java/handson/Task02b_UPDATE_Group.java

Knowledge based on git-blame:
jenschude: 42%

src/main/java/handson/Task03b_IMPORT_API.java

Knowledge based on git-blame:
jenschude: 28%

src/main/java/handson/Task03c_SYNC_PROJECTS.java

Knowledge based on git-blame:

src/main/java/handson/Task04a_STATEMACHINE.java

Knowledge based on git-blame:
jenschude: 41%

src/main/java/handson/Task06a_SEARCH.java

Knowledge based on git-blame:
jenschude: 73%

src/main/java/handson/Task07a_CUSTOMTYPES.java

Knowledge based on git-blame:
jenschude: 56%

src/main/java/handson/Task07b_CUSTOMOBJECTS.java

Knowledge based on git-blame:
jenschude: 50%

src/main/java/handson/Task07c_APIEXTENSION.java

Knowledge based on git-blame:
jenschude: 45%

src/main/java/handson/Task08a_SUBSCRIPTION.java

Knowledge based on git-blame:
jenschude: 35%

src/main/java/handson/Task09a_ERROR_HANDLING.java

Knowledge based on git-blame:
jenschude: 67%

src/main/java/handson/Task09b_SPHERECLIENT_LOGGING.java

Knowledge based on git-blame:
jenschude: 48%

src/main/java/handson/impl/ApiPrefixHelper.java

Knowledge based on git-blame:

src/main/java/handson/impl/CartService.java

Knowledge based on git-blame:
jenschude: 7%

src/main/java/handson/impl/ClientService.java

Knowledge based on git-blame:
jenschude: 14%

src/main/java/handson/impl/CustomerService.java

Knowledge based on git-blame:
jenschude: 8%

src/main/java/handson/impl/ImportService.java

Knowledge based on git-blame:
jenschude: 24%

src/main/java/handson/impl/OrderService.java

Knowledge based on git-blame:
jenschude: 12%

src/main/java/handson/impl/PaymentService.java

Knowledge based on git-blame:
jenschude: 25%

src/main/java/handson/impl/ProductSelectionService.java

Knowledge based on git-blame:

src/main/java/handson/impl/StateMachineService.java

Knowledge based on git-blame:
jenschude: 7%

src/main/resources/dev.properties.dist

Knowledge based on git-blame:
jenschude: 78%

src/main/resources/logback.xml

Knowledge based on git-blame:
jenschude: 12%

To learn more about /:\ gitStream - Visit our Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants