Skip to content

Commit

Permalink
Remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
mladens committed Sep 24, 2024
1 parent 7a9c0ec commit ac4ba70
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ private class SQSMessageBatch[F[_], T](
)
}
}.void
// TODO adapt error

override def nackAll: F[Unit] = F.fromCompletableFuture {
F.delay {
Expand All @@ -72,5 +71,5 @@ private class SQSMessageBatch[F[_], T](
req
)
}
}.void // TODO adapt error
}.void
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PubSubClientSuite extends QueueClientSuite {
ifTrue = IO.pure(("test-project", NoCredentialsProvider.create(), Some("localhost:8042"))),
ifFalse = for {
project <- string("GCP_PUBSUB_PROJECT")
credentials = NoCredentialsProvider.create() // TODO
credentials = NoCredentialsProvider.create()
} yield (project, credentials, None)
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private class PubSubMessageBatch[F[_], T](
.newBuilder()
.setSubscription(subscriptionName.toString)
.addAllAckIds(payload.map(_.underlying.getAckId).asJava)
.build()))).void // TODO mladens adapt error
.build()))).void

override def nackAll: F[Unit] = wrapFuture(
F.delay(
Expand All @@ -53,5 +53,5 @@ private class PubSubMessageBatch[F[_], T](
.setSubscription(subscriptionName.toString)
.setAckDeadlineSeconds(0)
.addAllAckIds(payload.map(_.underlying.getAckId).asJava)
.build()))).void // TODO mladens adapt error
.build()))).void
}

0 comments on commit ac4ba70

Please sign in to comment.