Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap deserialization errors in DeserializationException #13

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

satabin
Copy link
Collaborator

@satabin satabin commented Apr 5, 2024

This way, underlying deserializer errors are not leaked in the API, and users can handle this case specifically.

@satabin satabin requested a review from AL333Z April 5, 2024 08:36
This way, underlying deserializer errors are not leaked in the API, and
users can handle this case specifically.
@AL333Z
Copy link
Member

AL333Z commented Apr 5, 2024

Some thoughts about our high-level QueueSubscriber.
Right now they'll handle those failures and nack.
A possible evolution may be to let the client specify what to do in those scenarios (e.g. requeue with a delay, move to a dlq, etc..), e.g. via a partial function matching the failure and returning what to do.

@satabin
Copy link
Collaborator Author

satabin commented Apr 5, 2024

Some thoughts about our high-level QueueSubscriber. Right now they'll handle those failures and nack. A possible evolution may be to let the client specify what to do in those scenarios (e.g. requeue with a delay, move to a dlq, etc..), e.g. via a partial function matching the failure and returning what to do.

Tracked by #14

@satabin satabin merged commit 0d4db6a into main Apr 5, 2024
7 checks passed
@satabin satabin deleted the errors/deserialization branch April 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants