Make access do deserialized payload effectful #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserializing the content might fail if the payload is malformed. The idea is to make access to it effectful (with memoization) so that failure occurs when the payload is accessed. The logic behind it is that this is a business logic error to handle, not something that can be handled at the library level. This PR also introduces access to the `rawPayload` to handle malformed body.
Since we are in `0.x` series, allow for some breakage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing the content might fail if the payload is malformed. The idea is to make access to it effectful (with memoization) so that failure occurs when the payload is accessed. The logic behind it is that this is a business logic error to handle, not something that can be handled at the library level.
This PR also introduces access to the
rawPayloadto handle malformed body.