Introduce MessageBatch to QueuePuller
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for batched n/acking when underlying implementation supports it
AL333Z
approved these changes
Sep 25, 2024
core/src/main/scala/com/commercetools/queue/QueueSubscriber.scala
Outdated
Show resolved
Hide resolved
satabin
reviewed
Sep 25, 2024
satabin
reviewed
Sep 25, 2024
satabin
reviewed
Sep 25, 2024
satabin
reviewed
Sep 25, 2024
otel4s/src/test/scala/com/commercetools/queue/otel4s/MeasuringPullerSuite.scala
Outdated
Show resolved
Hide resolved
satabin
reviewed
Sep 25, 2024
testing/src/main/scala/com/commercetools/queue/testing/TestQueuePuller.scala
Outdated
Show resolved
Hide resolved
…PullerSuite.scala Co-authored-by: Lucas Satabin <[email protected]>
…uePuller.scala Co-authored-by: Lucas Satabin <[email protected]>
|
Looks overall good. One last thing: can you add documentation with a compiling example on the website (here) similar to the one we have for |
satabin
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new methods to
QueuePullerandQueueSubscriberfor processing messages via batches which allow acking/nacking all messages in a single call if the underlying client supports it. Implementations which do not provide dedicated batching methods will fallback to per-message acking which is not atomic.