Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More love for GCP Pub/Sub #57

Merged
merged 1 commit into from
Sep 26, 2024
Merged

More love for GCP Pub/Sub #57

merged 1 commit into from
Sep 26, 2024

Conversation

AL333Z
Copy link
Member

@AL333Z AL333Z commented Sep 24, 2024

GCP Pub/Sub is an interesting beast, this PR is fixing several stuff while also making the specs more reliable.

Learnings/gotchas:

  • monitoring for pubsub has been fixed, it required a separate GrpcTransportChannel (the target endpoint is different, monitoring.googleapis.com vs pubsub.googleapis.com)
  • AFAIK, there's no support for monitoring endpoints in the emulator, so QueueStatisticsSuite won't run there
  • in a proper infra, I noticed that the metrics will appear after ~5-10minutes or so (this is not really a surprise), thus several specs have been rewritten to avoid the need of fetching stats to run assertions. For the specs in QueueStatisticsSuite we will need to wait, and yeah, they're slow as hell but there's no other way to check their behaviour otherwise
  • as we knew already, pubsub doesn't natively support metrics for in-flight and delayed messages (actually, it doesn't support delayed messages OOB, but we may find creative ways of deriving this value since we're actually implementing those via some trick, internally, Add support for delayed messages stats in gcp pubsub #58)

@AL333Z AL333Z requested a review from satabin September 24, 2024 14:38
@AL333Z AL333Z merged commit 5690611 into main Sep 26, 2024
10 checks passed
@AL333Z AL333Z deleted the configure-gcp-specs branch September 26, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants