Add specific error model #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelusnegur
approved these changes
Mar 27, 2024
JPisCoding
approved these changes
Mar 27, 2024
aws/sqs/src/main/scala/com/commercetools/queue/aws/sqs/package.scala
Outdated
Show resolved
Hide resolved
AL333Z
approved these changes
Mar 29, 2024
JPisCoding
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's define common exception we want to expose in the API. The goal is also to avoid leaking concrete exceptions at top level so that client code can only check for
QueueExceptions.We can discuss the pre-defined exception. I added what came to my mind but maybe we want to define more.
Closes #5