-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency jose to v5 - abandoned #3540
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
81ce5d0
to
3955bc1
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -1,19 +1,49 @@ | |||
import { JWT, JWK, JWKS } from 'jose'; | |||
import { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to rebuild the fixtures because most of the jose
APIs have changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
||
const jwksStore = new JWKS.KeyStore([keyRS256]); | ||
async function initialize() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jose
APIs are now async so I found this initializer the simplest way to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also check how we initialize this in our MC services (auth
package).
Anyway, if it does the job all good.
@@ -2,6 +2,7 @@ const modulesWithFaultyExports = [ | |||
'@react-hook/resize-observer', | |||
'@react-hook/passive-layout-effect', | |||
'@react-hook/latest', | |||
'jose', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed as jose
now only exports esm module.
// This is required for the `jose` library to work in the test environment. | ||
// We use it in the packages-backend/express package. | ||
// Reference: https://github.com/jestjs/jest/issues/4422#issuecomment-770274099 | ||
Uint8Array: Uint8Array, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the trickiest part as I was having a very weird error but finally got some help in the linked GitHub issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finally upgrade this!
PS: don't forget a changeset 😉
Ok, the current state of the PR is as far I could get but still is not valid. I managed to update to The problem seem related to the new version using the Since this is a dependency we only use for one test suite in the repository, @emmenko mentioned we could maybe just keep the current version and forget about the update. @commercetools/shield-team-ext-and-infra please let me know your thoughts. 🙏 |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
2.0.7
->5.4.0
Release Notes
panva/jose (jose)
v5.4.0
Compare Source
Features
Refactor
v5.3.0
Compare Source
Features
Refactor
v5.2.4
Compare Source
Refactor
v5.2.3
Compare Source
Refactor
v5.2.2
Compare Source
Fixes
v5.2.1
Compare Source
Fixes
v5.2.0
Compare Source
Features
v5.1.3
Compare Source
v5.1.2
Compare Source
Fixes
v5.1.1
Compare Source
Refactor
v5.1.0
Compare Source
Features
v5.0.2
Compare Source
Fixes
v5.0.1
Compare Source
Fixes
v5.0.0
Compare Source
⚠ BREAKING CHANGES
KeyLike type is now a second optional type argument following a type
for the JWT Claims Set (aka payload)
functions now requires the use of the keyManagementAlgorithms option
to explicitly opt-in for their use.
importJWK will no longer return CryptoKey or KeyObject for "oct" (octet
sequence) JWK key types, it will instead always return a Uint8Array
formed from the "k" (Key Value) Parameter regardless of the other JWK
Parameters that may be present.
no longer supported. Node.js 18, 20, and 21 and future releases are
the ones that remain supported.
is no longer supported by this JOSE implementation.
Features
Reverts
Refactor
v4.15.5
Compare Source
Fixes
v4.15.4
Compare Source
Fixes
v4.15.3
Compare Source
v4.15.2
Compare Source
Fixes
v4.15.1
Compare Source
Fixes
v4.15.0
Compare Source
Features
v4.14.6
Compare Source
Fixes
v4.14.5
Compare Source
Refactor
v4.14.4
Compare Source
Refactor
v4.14.3
Compare Source
Reverts
v4.14.2
Compare Source
Fixes
v4.14.1
Compare Source
v4.14.0
Compare Source
Features
v4.13.2
Compare Source
Refactor
v4.13.1
Compare Source
Fixes
v4.13.0
Compare Source
Features
Fixes
v4.12.2
Compare Source
Fixes
v4.12.1
Compare Source
Refactor
v4.12.0
Compare Source
Features
v4.11.4
Compare Source
Fixes
v4.11.3
Compare Source
Fixes
v4.11.2
Compare Source
Refactor
v4.11.1
Compare Source
v4.11.0
Compare Source
Features
Fixes
v4.10.4
Compare Source
Fixes
v4.10.3
Compare Source
v4.10.2
Compare Source
v4.10.1
Compare Source
v4.10.0
Compare Source
Features
Fixes
v4.9.3
Compare Source
Refactor
v4.9.2
Compare Source
Fixes
v4.9.1
Compare Source
Fixes
v4.9.0
Compare Source
Features
Refactor
v4.8.3
Compare Source
v4.8.1
Compare Source
Fixes
v4.8.0
Compare Source
Features
v4.7.0
Compare Source
Features
v4.6.2
Compare Source
Fixes
v4.6.1
Compare Source
v4.6.0
Compare Source
Features
v4.5.3
Compare Source
Fixes
v4.5.2
Compare Source
Fixes
v4.5.1
Compare Source
Fixes
v4.5.0
Compare Source
Features
Fixes
v4.4.0
Compare Source
Features
v4.3.9
Compare Source
Fixes
v4.3.8
Compare Source
v4.3.7
Compare Source
Fixes
v4.3.6
Compare Source
Fixes
v4.3.5
Compare Source
Fixes
v4.3.4
Compare Source
Fixes
v4.3.3
Compare Source
Fixes
v4.3.2
Compare Source
Fixes
v4.3.0
Compare Source
Features
v4.2.1
Compare Source
Fixes
v4.2.0
Compare Source
Features
v4.1.5
Compare Source
Fixes
v4.1.4
Compare Source
Fixes
v4.1.3
Compare Source
Fixes
v4.1.2
Compare Source
Fixes
v4.1.1
Compare Source
Fixes
v4.1.0
Compare Source
Features
v4.0.4
Compare Source
Fixes
v4.0.3
Compare Source
Fixes
v4.0.2
Compare Source
Fixes
v4.0.1
Compare Source
Fixes
v4.0.0
Compare Source
⚠ BREAKING CHANGES
just "jose". For example,
import { jwtVerify } from 'jose/jwt/verify'
is now just
import { jwtVerify } from 'jose'
.removed in favour of just "jose" named exports.
jose/util/random
was removed.jose/jwk/thumbprint
named exportis renamed to
calculateJwkThumbprint
, nowimport { calculateJwkThumbprint } from 'jose'
jose/jwk/parse
module wasremoved, use
import { importJWK } from 'jose'
instead.jose/jwk/from_key_like
module wasremoved, use
import { exportJWK } from 'jose'
instead.Refactor
v3.20.4
Compare Source
Fixes
v3.20.3
Compare Source
Fixes
v3.20.2
Compare Source
Fixes
v3.20.1
Compare Source
Fixes
v3.20.0
Compare Source
Features
Fixes
v3.19.0
Compare Source
Features
v3.18.0
Compare Source
Features
v3.17.0
Compare Source
Features
Ed25519
(0967369)v3.16.1
Compare Source
Fixes
v3.16.0
Compare Source
Features
v3.15.5
Compare Source
Fixes
v3.15.4
Compare Source
Fixes
v3.15.3
Compare Source
Fixes
v3.15.2
Compare Source
v3.15.1
Compare Source
Fixes
v3.15.0
Compare Source
Features
Fixes
v3.14.4
Compare Source
Fixes
v3.14.3
Compare Source
Fixes
v3.14.2
Compare Source
Fixes
v3.14.1
Compare Source
Fixes
v3.14.0
Compare Source
Features
Fixes
v3.13.0
Compare Source
Features
v3.12.3
Compare Source
Fixes
v3.12.2
Compare Source
Performance
v3.12.1
Compare Source
Fixes
v3.12.0
Compare Source
Features
v3.11.6
Compare Source
Fixes
v3.11.5
Compare Source
Fixes
v3.11.4
Compare Source
Fixes
v3.11.3
Compare Source
Fixes
v3.11.2
Compare Source
Fixes
v3.11.1
Compare Source
Fixes
v3.11.0
Compare Source
Features
v3.10.0
Compare Source
Features
v3.9.0
Compare Source
Features
v3.8.0
Compare Source
Features
v3.7.1
Compare Source
Fixes
v3.7.0
Compare Source
Features
Fixes
v3.6.2
Compare Source
Fixes
v3.6.1
Compare Source
Fixes
v3.6.0
Compare Source
Features
v3.5.4
Compare Source
Fixes
v3.5.3
Compare Source
Fixes
v3.5.2
Compare Source
Performance
v3.5.1
Compare Source
Fixes
v3.5.0
Compare Source
Features
v3.4.0
Compare Source
Features
v3.3.2
Compare Source
Fixes
v3.3.1
Compare Source
Fixes
v3.3.0
Compare Source
Features
crit
header parameters (5163116), closes #123Fixes
v3.2.0
Compare Source
Features
v3.1.3
Compare Source
Fixes
v3.1.2
Compare Source
Fixes
v3.1.1
Compare Source
Fixes
v3.1.0
Compare Source
Features
v3.0.2
Compare Source
Fixes
v3.0.1
Compare Source
Fixes
v3.0.0
Compare Source
⚠ BREAKING CHANGES
Features
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.