Default typeHint field value
#522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
reviewed
Aug 2, 2023
| String defaultType() default ""; |
There was a problem hiding this comment.
I guess you though about using null vs "". What arguments put in the balance of using ""?
There was a problem hiding this comment.
Not really, i just saw it was default for JSONTypeHint.value and followed that
yanns
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add alternatives to existing types with an ADT in a backwards compatible way we declare the current type to be one of the implementations of new hierarchy. New clients will always be sending type hints whereas old will not.
This PR expands
JSONTypeHintFieldwith additional parameter, designating which impl to fallback to if hint is not provided at all.