filters design modifications for async select input #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 30, 2024 14:30
…ct when used in a filter component
…ct when used in a filter component
…ct when used in a filter component
ddouglasz
requested review from
stephsprinkle,
jaikamat,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: 66e84c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ddouglasz
commented
Oct 30, 2024
| ? 'Search' | ||
| : intl.formatMessage(messages.placeholder); | ||
|
|
||
| // TODO: uncomment to replace placeholder logic once select-input PR for this has been merged. |
There was a problem hiding this comment.
When the select-input PR is merged, I will uncomment this since they will be using the same messages keys.
|
There is a slight visual regression in the input field, which has been fixed in the select-uitils in here, so when that is merged, this will work as expected. |
ddouglasz
commented
Oct 31, 2024
| @@ -144,3 +144,35 @@ BasicExample.args = { | |||
| showOptionGroupDivider: false, | |||
| iconLeft: undefined, | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
This is mainly for testing simplicity and will be removed before merging.
There was a problem hiding this comment.
For some reason, label/placeholder and input break lines after selection:
misama-ct
reviewed
Nov 1, 2024
| @@ -144,3 +144,35 @@ BasicExample.args = { | |||
| showOptionGroupDivider: false, | |||
| iconLeft: undefined, | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
For some reason, label/placeholder and input break lines after selection:
| // const placeholder = | ||
| // props.appearance === 'filter' && !props.placeholder | ||
| // ? intl.formatMessage(messages.selectInputAsFilterPlaceholder) | ||
| // : props.placeholder || intl.formatMessage(messages.placeholder); |
There was a problem hiding this comment.
You can simplify this condition. Only if there is no props.placeholder you need to check which default-placeholder to pick:
const placeholder = props.placeholder || intl.formatMessage(props.appearance === 'filter' ? messages.selectInputAsFilterPlaceholder : messages.placeholder);
There was a problem hiding this comment.
updated here: 66e84c2
Thank you
| ? false | ||
| : props.controlShouldRenderValue | ||
| } | ||
| appea |
There was a problem hiding this comment.
updated here: 66e84c2
Thank you
Thank you, I mentioned it here 🙂. I fixed it in the utils in the first PR and since they all share the same util, I will wait for when that is merged and it will handle it in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces new properties to handle optional styling for the async-select-input when used as a filter component. The most important changes include the addition of the
filterappearance option and the incorporation of a search icon when this appearance is selected.Filter-specific changes: