Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace SemVer type literals by respective constants #796

Merged
merged 1 commit into from
Jul 29, 2023
Merged

refactor: replace SemVer type literals by respective constants #796

merged 1 commit into from
Jul 29, 2023

Conversation

paduszyk
Copy link
Contributor

Description

This is a small PR updating a few lines of code where SemVer types (major/minor/patch) are referred to as literal strings instead of constants defined in commitizen.defaults module.

I guess the changes made do not require tests.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 98.36% and project coverage change: +0.15% 🎉

Comparison is base (eb39f8b) 97.31% compared to head (756f088) 97.46%.
Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
+ Coverage   97.31%   97.46%   +0.15%     
==========================================
  Files          42       42              
  Lines        2045     2090      +45     
==========================================
+ Hits         1990     2037      +47     
+ Misses         55       53       -2     
Flag Coverage Δ
unittests 97.46% <98.36%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...en/cz/conventional_commits/conventional_commits.py 100.00% <ø> (ø)
commitizen/providers.py 97.52% <90.00%> (+0.22%) ⬆️
commitizen/commands/init.py 87.50% <94.44%> (+0.06%) ⬆️
commitizen/commands/bump.py 97.63% <96.55%> (-0.52%) ⬇️
commitizen/version_schemes.py 98.42% <98.42%> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/bump.py 100.00% <100.00%> (ø)
commitizen/changelog.py 100.00% <100.00%> (ø)
commitizen/changelog_parser.py 96.96% <100.00%> (+0.04%) ⬆️
commitizen/cli.py 94.20% <100.00%> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W merged commit 9b010bb into commitizen-tools:master Jul 29, 2023
18 checks passed
@paduszyk paduszyk deleted the replace-semver-literals-by-constants branch July 29, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants