Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of union types #720

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Add description of union types #720

merged 2 commits into from
Jul 29, 2023

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Jul 22, 2023

This request is to solve #716 by clarifying:

  • an array such as [int, string] indicates a union type of its elements, and
  • its elements may be duplicated.

@mr-c
Copy link
Member

mr-c commented Jul 23, 2023

@tom-tan Can you fix the test failures?

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #720 (a8a9e1e) into main (b8c7fc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files          22       22           
  Lines        4507     4507           
  Branches     1244     1244           
=======================================
  Hits         3773     3773           
  Misses        469      469           
  Partials      265      265           

@tom-tan
Copy link
Member Author

tom-tan commented Jul 28, 2023

The log of the unittests shows that it is already finished successfully but the status is not updated yet...

@mergify mergify bot merged commit ff30991 into main Jul 29, 2023
34 checks passed
@mergify mergify bot deleted the clarify-union-types branch July 29, 2023 08:21
@tom-tan
Copy link
Member Author

tom-tan commented Jul 29, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants