Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dezerialize #16

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat: add dezerialize #16

merged 1 commit into from
Jan 9, 2024

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Dec 23, 2023

I've sought to graft your dezerial branch changes onto main, with only a few changes from that code (e.g., merging in the tests for 100% coverage besides ui.ts), including dropping the files you dropped (besides ui.ts and its dependency infer.ts).

I don't claim to have too deep of an understanding of the types, but thankfully the branch seemed to already have most of that work done.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@brettz9
Copy link
Contributor Author

brettz9 commented Jan 7, 2024

@Gregoor : Think you'll be able to take a look?

Copy link
Collaborator

@Gregoor Gregoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Do you also want to update the README? I don't have merge rights, so I can't press the green button on this though. @heikir you wanna merge?

@heikir heikir merged commit 732ee51 into commonbaseapp:main Jan 9, 2024
@heikir
Copy link

heikir commented Jan 9, 2024

Done. Let me look into the permissions thing.

@brettz9 brettz9 deleted the dezerialize branch January 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants