Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser #28

Closed
wants to merge 1 commit into from
Closed

Browser #28

wants to merge 1 commit into from

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jun 19, 2024

feat: add esm build

Also:

  • docs: adds browser demo

@brettz9 brettz9 force-pushed the browser branch 3 times, most recently from b16ba20 to 980ae73 Compare June 21, 2024 03:59
@brettz9 brettz9 mentioned this pull request Jun 21, 2024
@brettz9 brettz9 force-pushed the browser branch 2 times, most recently from fa8aaef to c7927b4 Compare June 21, 2024 07:51
@brettz9 brettz9 mentioned this pull request Jun 21, 2024
@brettz9 brettz9 force-pushed the browser branch 6 times, most recently from 4bd9f67 to a9db3e9 Compare June 27, 2024 07:50
@Gregoor
Copy link
Collaborator

Gregoor commented Jun 27, 2024

While I like the simplicity of having browser ready JS, I don't like vendoring in zod. My leaning would be to just use vite, as we're already depending on it anyway

@brettz9
Copy link
Contributor Author

brettz9 commented Jun 27, 2024

Sorry, so you mean to include the demo, but for local use only—using Vite instead of Rollup/node-static, and not doing the GitHub Pages-ready bundling at all, right?

@brettz9 brettz9 mentioned this pull request Jun 27, 2024
@brettz9
Copy link
Contributor Author

brettz9 commented Jun 27, 2024

I've added #37 . If that meets your needs, I can rebase the other PRs fairly easily on top of it.

@Gregoor
Copy link
Collaborator

Gregoor commented Jun 27, 2024

Uuh I must’ve missed the gh pages part sorry, will check again (looking at it from my phone atm, so it will be later).
But in general I’d also use vite to do a static GitHub pages export

@brettz9
Copy link
Contributor Author

brettz9 commented Jun 27, 2024

Re: GitHub Pages, there's no special code for it--just by bundling it in vendor, the main branch could be configured on GitHub to run the demo web app.

But with your preference for Vite, though I've gotten things going with local use of vite in #37, if you wouldn't mind, I'll leave any static production deployment work to you, as the production configuration looks a little involved, and you might have your own ideas about how to do it anyways.

@Gregoor
Copy link
Collaborator

Gregoor commented Jun 28, 2024

Happy to take prod deployment over, but it's gonna be a week or so until I have time to look into it

@brettz9 brettz9 force-pushed the browser branch 3 times, most recently from 9c4ba7c to f62ba56 Compare July 16, 2024 15:20
@brettz9 brettz9 force-pushed the browser branch 6 times, most recently from 0bec7ed to 2afdd91 Compare August 5, 2024 17:24
@brettz9 brettz9 force-pushed the browser branch 2 times, most recently from 23310c9 to 46a2630 Compare August 8, 2024 10:06
@brettz9 brettz9 force-pushed the browser branch 2 times, most recently from 83841cd to 5cb5a7e Compare August 17, 2024 15:30
@brettz9
Copy link
Contributor Author

brettz9 commented Aug 17, 2024

I've amended this PR to be on top of a commit which removes React. I can amend to add back React if desired, but it sounded like that was the way you may be going.

@brettz9 brettz9 force-pushed the browser branch 3 times, most recently from 71885bd to f2d07ad Compare September 5, 2024 14:51
@brettz9
Copy link
Contributor Author

brettz9 commented Sep 5, 2024

Woohoo! Down to the last PR (assuming you want to remove React which this one has a commit for), though I know as it requires your intervention to get it deployed to production, it may take time for you to get to it. Should be great to have a browser build merged, and I can perhaps finally leave you with some peace. :-)

Also:
- docs: adds demo
@brettz9
Copy link
Contributor Author

brettz9 commented Sep 5, 2024

I dropped the removal of infer.ts from this PR (though I'll leave it to you on exporting it).

@Gregoor Gregoor mentioned this pull request Sep 6, 2024
@brettz9 brettz9 closed this Sep 27, 2024
@brettz9
Copy link
Contributor Author

brettz9 commented Sep 27, 2024

Closed in favor of #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants