-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser #28
Browser #28
Conversation
b16ba20
to
980ae73
Compare
fa8aaef
to
c7927b4
Compare
4bd9f67
to
a9db3e9
Compare
While I like the simplicity of having browser ready JS, I don't like vendoring in zod. My leaning would be to just use vite, as we're already depending on it anyway |
Sorry, so you mean to include the demo, but for local use only—using Vite instead of Rollup/node-static, and not doing the GitHub Pages-ready bundling at all, right? |
I've added #37 . If that meets your needs, I can rebase the other PRs fairly easily on top of it. |
Uuh I must’ve missed the gh pages part sorry, will check again (looking at it from my phone atm, so it will be later). |
Re: GitHub Pages, there's no special code for it--just by bundling it in But with your preference for Vite, though I've gotten things going with local use of vite in #37, if you wouldn't mind, I'll leave any static production deployment work to you, as the production configuration looks a little involved, and you might have your own ideas about how to do it anyways. |
Happy to take prod deployment over, but it's gonna be a week or so until I have time to look into it |
9c4ba7c
to
f62ba56
Compare
0bec7ed
to
2afdd91
Compare
23310c9
to
46a2630
Compare
83841cd
to
5cb5a7e
Compare
I've amended this PR to be on top of a commit which removes React. I can amend to add back React if desired, but it sounded like that was the way you may be going. |
71885bd
to
f2d07ad
Compare
Woohoo! Down to the last PR (assuming you want to remove React which this one has a commit for), though I know as it requires your intervention to get it deployed to production, it may take time for you to get to it. Should be great to have a browser build merged, and I can perhaps finally leave you with some peace. :-) |
Also: - docs: adds demo
I dropped the removal of |
Closed in favor of #46 |
feat: add esm build
Also: