-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta schema #32
Merged
Merged
Meta schema #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
582c268
to
d47b0a7
Compare
Merged
67ae919
to
03030af
Compare
Merged
80d3c76
to
6befe97
Compare
Merged
2a761c0
to
d2c40aa
Compare
Realized I had my status set to Busy for a while, but I'm actually available now if you're able to review... :-) |
Funky idea! Two comments:
|
4859eb7
to
19806d5
Compare
Sure, done.
No, it's not necessary. The idea was just to make it easier if hand-crafting the JSON, but that's fine. Changed back. |
The large block in the testing file was moved and also changed to complete test coverage. |
Also: - Add `symbol` to SzKey
Gregoor
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add meta schema
Has the following advantages:
Also:
Make object'sproperties
optionalsymbol
to SzKey