Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta schema #32

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Meta schema #32

merged 2 commits into from
Jul 15, 2024

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jun 23, 2024

feat: add meta schema

Has the following advantages:

  1. Convey the syntax to learners of Zodex JSON
  2. Sanity check our own test schemas and user schemas
  3. Facilitate the building of a UI to input an arbitrary Zodex JSON schema

Also:

  • Make object's properties optional
  • Add symbol to SzKey

@brettz9 brettz9 force-pushed the meta-schema branch 2 times, most recently from 582c268 to d47b0a7 Compare June 23, 2024 09:07
@brettz9 brettz9 mentioned this pull request Jun 23, 2024
@brettz9 brettz9 force-pushed the meta-schema branch 9 times, most recently from 67ae919 to 03030af Compare June 28, 2024 14:28
@brettz9 brettz9 mentioned this pull request Jul 1, 2024
@brettz9 brettz9 force-pushed the meta-schema branch 6 times, most recently from 80d3c76 to 6befe97 Compare July 2, 2024 22:08
@brettz9 brettz9 mentioned this pull request Jul 3, 2024
@brettz9 brettz9 force-pushed the meta-schema branch 9 times, most recently from 2a761c0 to d2c40aa Compare July 13, 2024 07:21
@brettz9
Copy link
Contributor Author

brettz9 commented Jul 15, 2024

Realized I had my status set to Busy for a while, but I'm actually available now if you're able to review... :-)

@Gregoor
Copy link
Collaborator

Gregoor commented Jul 15, 2024

Funky idea! Two comments:

  1. I'd rename it to schema.zodex.json so that all kinds of tooling works by default (mainly thinking about editors and syntax highlighting)
  2. I'd prefer not to make properties optional. I prefer things only to be in expressible in as many ways as necessary (in this case, an empty object). Or is it necessary?

@brettz9 brettz9 force-pushed the meta-schema branch 2 times, most recently from 4859eb7 to 19806d5 Compare July 15, 2024 11:48
@brettz9
Copy link
Contributor Author

brettz9 commented Jul 15, 2024

  1. I'd rename it to schema.zodex.json so that all kinds of tooling works by default (mainly thinking about editors and syntax highlighting)

Sure, done.

  1. I'd prefer not to make properties optional. I prefer things only to be in expressible in as many ways as necessary (in this case, an empty object). Or is it necessary?

No, it's not necessary. The idea was just to make it easier if hand-crafting the JSON, but that's fine. Changed back.

@brettz9
Copy link
Contributor Author

brettz9 commented Jul 15, 2024

The large block in the testing file was moved and also changed to complete test coverage.

Also:
- Add `symbol` to SzKey
@Gregoor Gregoor merged commit a121b23 into commonbaseapp:main Jul 15, 2024
5 checks passed
@brettz9 brettz9 deleted the meta-schema branch July 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants