-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify wording in spec for character groups #618
Conversation
Closes GH-604. |
Thanks for the review @JohelEGP! I’ll leave the rest up to see what John thinks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great! Thanks for going through the spec with such care.
Most of my comments are the same thing. You may have had a reason for writing "indented N spaces of indentation"; so maybe there's something I'm missing?
It’s a bit hidden, so to clarify, my response to your “of indentation” question is here: #618 (comment) |
Summarizing here for convenience: I commented:
You said:
I figured that was the reason. But I wonder whether adding "of indentation" is going to convey this reliably. Is the notion of "virtual space" defined under that name in the spec as you've revised it? If so, maybe we could say "indented four or more virtual spaces"? (with a hyperlink on virtual spaces everywhere it is used) Another possibility would be just to rephrase. Instead of "indented four spaces of indentation," one could say something like "with four spaces of indentation"? |
The parsing spec I’m working on defines virtual spaces here (and elaborates more in the tabs and input stream sections). That spec is focussed on parsing though, and CM isn’t. I think it is good for CM to not focus on parsing (in line with the content question in GH-605 and GH-622), both have a “raison d'être” (reason for being). The terms may be useful though, and I could include some of that here (depending on how you want to go about it) |
What about the minimal change suggested here?
|
(edit: whoops, messed up) |
Sorry about that, I now see the problem was only referencing “indentation” twice, and that you suggest using it once. I think that’s good! |
Co-Authored-By: Johel Ernesto Guerrero Peña <[email protected]>
Co-Authored-By: Johel Ernesto Guerrero Peña <[email protected]>
Co-Authored-By: Johel Ernesto Guerrero Peña <[email protected]>
Co-Authored-By: Johel Ernesto Guerrero Peña <[email protected]>
Co-Authored-By: Johel Ernesto Guerrero Peña <[email protected]>
@jgm Sorry for forgetting about this. Rebased and fixed those duplicate mentions of indentation. Gah, sorry again—what do you think? |
Thanks! I'll have a look before too long. |
Excellent, thanks for all of this! |
|
This PR has nothing to do with that. |
@wooorm THIS HAPPENS IN ALL MARKDOWN DOCS, NOT ONLY MDX!!!!!!!!!!!!!!!!!!!!!!!!!!! |
Read what I said. You are spamming an unrelated old issue. You are rude. |
This has nothing to do with that discussion! |
Again, please read. Yes it does. This PR is about words. It doesn’t change anything in markdown. The behavior has always been the same. #650. |
I'm sorry for going a little overboard. I was a bit ticked off to discover a much more serious and much neglected issue than that discussion.
I got it. |
@wooorm I would like to take an opportunity to apologize for making you feel very uncomfortable by blowing a false accusation due to lack of prior research, calling your important changes "the culprit" in anger, and closing dialogue with too much rhetoric. (you might not be able to read this comment anymore though) I apologize to everyone else for messing up this place with unnecessary and offensive comments. |
Thank you! I do accept your apology. You are forgiven :) |
newline
to line feed (the LF,\n
character) or line ending (the concept)This is a substantial change and needs a thorough review
Open questions: