LP-486 Choose principal place of business page #186
Conversation
| setLocalesEnabled(false); | ||
| appDevDependencies.addressLookUpGateway.setError(false); | ||
| appDevDependencies.cacheRepository.feedCache({ | ||
| [`${config.APPLICATION_CACHE_KEY_PREFIX_REGISTRATION}registered_office_address`]: |
There was a problem hiding this comment.
Will update this, it is breaking tests atm
There was a problem hiding this comment.
Looked this is used by the controller for the address lookup it might need renaming to something more generic.
There was a problem hiding this comment.
can you add an if statement into the address controller here https://github.com/companieshouse/limited-partnerships-web/blob/main/src/presentation/controller/addressLookUp/Controller.ts#L250, to say, if pagetype == your page, use a different cache key for the address?
|
CI: No security warnings found |
|
CI: No security warnings found |
|
CI: No security warnings found |
|
|
||
| {% set pageTitle = i18n.choosePrincipalPlaceOfBusinessPage.title %} | ||
|
|
||
| {% set addressItems = [] %} |
There was a problem hiding this comment.
This should be extracted into a common component used by the various choose pages
Look at postcode
|
|
||
| {% include "includes/proposed-name.njk" %} | ||
|
|
||
| {{ govukRadios({ |
There was a problem hiding this comment.
This should be extracted into a common component used by the various choose pages
Look at postcode
|
SonarQube Quality Gate
|
|
CI: No security warnings found |
JIRA link
https://companieshouse.atlassian.net/browse/LP-486
Change description
Work checklist
Merge instructions
We are committed to keeping commit history clean, consistent and linear. To achieve this commit should be structured as follows:
and contain the following structural elements:
BREAKING CHANGE:introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,fix:andfeat:are allowed, for examplebuild:,chore:,ci:,docs:,style:,refactor:,perf:,test:, and others,BREAKING CHANGE: <description>may be provided.