-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-open configured group windows at startup #162
base: master
Are you sure you want to change the base?
Conversation
# Joined groups can be auto-opened in a specified order. | ||
# Each key describes the window index, and the value must be the group name. | ||
# Indexes begin at 1 due to index 0 being reserved for the console window. | ||
[groups] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of the section and use the following notation instead:
group[1] = firstgroup
group[2] = secondgroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would complicate the parsing as well as the error handling when indexes are missing, but could be done.
because the ini package decodes into a map, we can't (easily) iterate through the settings in the file order either. using a unique section for only these settings allows us to at least initially know how many k/v fields were set.
I'm also thinking that we should use autoopen as the section name (or top-level 'autoopen[N]' keys) in case we want to distinguish between groups and direct chats in the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sections in INI are worse than INI itself imo. Really would prefer named arrays of sorts. chat[1]
group[3]
etc.
A [groups] section is added to the zkclient config file and must specify 'index = name' pairs for each group name and the window index. This is handy to keep groupchat windows in a common location across client restarts.
A [groups] section is added to the zkclient config file and must
specify 'index = name' pairs for each group name and the window index.
This is handy to keep groupchat windows in a common location across
client restarts.