[HOTFIX] Do not de-activate comments just because strict moderation is enabled. #1887
+80
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When strict moderation is enabled, new comments were being automatically flagged as
inactive
resulting in false negative messaging regarding the spam/toxicity filter.However we already use the
comment.mod
value to track comments which need moderation. There is no need to mark theminactive
unless an actual filter is triggered.Also in this PR is the help text improvements #1886
and java version updates for 'math'.
Result:
Strict Moderation ON:
Strict Moderation OFF:
Moderation can be toggled ON/OFF with the expected effect:
TODO (future PR)
[ ] Cypress tests for the above states
[ ] Adjust the warning in client-admin depending on if Jigsaw is active for that deployment or not