Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Do not de-activate comments just because strict moderation is enabled. #1887

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

ballPointPenguin
Copy link
Contributor

@ballPointPenguin ballPointPenguin commented Jan 29, 2025

When strict moderation is enabled, new comments were being automatically flagged as inactive resulting in false negative messaging regarding the spam/toxicity filter.

However we already use the comment.mod value to track comments which need moderation. There is no need to mark them inactive unless an actual filter is triggered.

Also in this PR is the help text improvements #1886
and java version updates for 'math'.

Result:

Screenshot 2025-01-29 at 01 24 49

Strict Moderation ON:

  • all user comments will appear in the moderation tab and must be approved
  • only comments which were flagged by an actual filter will show a warning message
  • any comment, flagged or not, can be approved and shown to voters

Strict Moderation OFF:

  • user comments that are flagged as spam/toxic will not be shown to voters unless approved
  • other user comments will be shown to voters, unless/until they are rejected by moderator

Moderation can be toggled ON/OFF with the expected effect:

  • Unmoderated comments will be either hidden or shown to voters accordingly

TODO (future PR)

[ ] Cypress tests for the above states
[ ] Adjust the warning in client-admin depending on if Jigsaw is active for that deployment or not

@ballPointPenguin ballPointPenguin merged commit 35ead42 into stable Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants