Add emscripten automated tests #483
Open
+322
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 9 9
Lines 3552 3552
=======================================
Hits 2528 2528
Misses 1024 1024 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mcbarton
force-pushed
the
wip]-add-automated-wasm-tests
branch
2 times, most recently
from
f3d8b34 to
e211109
Compare
mcbarton
force-pushed
the
wip]-add-automated-wasm-tests
branch
8 times, most recently
from
82343f6 to
f8250bd
Compare
mcbarton
force-pushed
the
wip]-add-automated-wasm-tests
branch
from
dad83f5 to
8b62073
Compare
mcbarton
force-pushed
the
wip]-add-automated-wasm-tests
branch
5 times, most recently
from
027e9a3 to
ab5976a
Compare
mcbarton
changed the title
mcbarton
force-pushed
the
wip]-add-automated-wasm-tests
branch
from
bba850e to
123e15c
Compare
vgvassilev
reviewed
Feb 9, 2025
lib/Interpreter/CMakeLists.txt
Outdated
|
|
||
| if(EMSCRIPTEN) | ||
| # Read the undefined symbols from the text file | ||
| file(READ "${CMAKE_SOURCE_DIR}/lib/Interpreter/undefined_symbols.txt" SYMBOLS_LIST) |
There was a problem hiding this comment.
Two things:
- Doesn't the emscripten linker allow linker scripts?
- This file should be called
exports.ldor something like that...
There was a problem hiding this comment.
I'm not aware of linker scripts. Can you point me a resource about them? I'll remame the file as suggested.
There was a problem hiding this comment.
There was a problem hiding this comment.
Addressed point 2 of renaming the file. Point 1 will take some more investigation on my part. My initial attempts to use a linker script ended in failure. Apart from this point I believe this PR is ready for another review when your available.
mcbarton
force-pushed
the
wip]-add-automated-wasm-tests
branch
from
8ec905a to
827b696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
My first PR to add automated emscripten tests became broken for unknown reasons (see #448). This PR is another attempt to added emscripten tests to CppInterOp
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist