Added target_compile_definitions for XEUS_SEARCH_PATH #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #ifdef XEUS_SEARCH_PATH | ||
| std::string search_path = XEUS_SEARCH_PATH; | ||
| std::istringstream iss(search_path); |
There was a problem hiding this comment.
warning: no header providing "std::istringstream" is directly included [misc-include-cleaner]
src/xinterpreter.cpp:19:
- #ifndef EMSCRIPTEN
+ #include <sstream>
+ #ifndef EMSCRIPTEN| std::string search_path = XEUS_SEARCH_PATH; | ||
| std::istringstream iss(search_path); | ||
| std::string path; | ||
| while (std::getline(iss, path, ':')) { |
There was a problem hiding this comment.
warning: no header providing "std::getline" is directly included [misc-include-cleaner]
while (std::getline(iss, path, ':')) {
^
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 80.72% 80.85% +0.13%
==========================================
Files 19 19
Lines 970 977 +7
Branches 93 95 +2
==========================================
+ Hits 783 790 +7
Misses 187 187
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a change to the build system by adding a
target_compile_definitionsdirective forXEUS_SEARCH_PATH. The added definition dynamically sets the include directories for thexeus-cppproject by joining the values of theINCLUDE_DIRECTORIESproperty.I have tried to take a similar approach as was taken for xeus-cling.
Fixes #175
Type of change
Please tick all options which are relevant.