Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node/npm to compose file #1432

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

pscheit
Copy link
Contributor

@pscheit pscheit commented Mar 8, 2024

Does npm install and npm run build once docker compose up is used.

Can put this to https://docs.docker.com/compose/profiles/ if needed. But dont think so.

  • version: is not read from compose v2 anymore (always uses the latest)
  • anonymous volumes can be now created without a top level entry in volume

@chr-hertel
Copy link
Contributor

i usually prefer not to mount the working directory to a container and work with symfony cli and nvm to have the runtimes on host, but that's opinionated i guess - but feels a bit inconsistent to me now to have a node container, but no php one.

what about adding the override to ignore now?

@pscheit
Copy link
Contributor Author

pscheit commented Mar 8, 2024

You mean adding the profile, so that its not started automatically?

If this doesn provide value to other Docker users I am fine to not merge this

@chr-hertel
Copy link
Contributor

No, the changes make sense and adding a profile to the node one or adding docker-compose.override.yml to .gitignore or both would be totally compatible with my way to use the docker setup

@pscheit
Copy link
Contributor Author

pscheit commented Mar 8, 2024

yeah, this is what I would prefer over profile as well.

Would add docker-compose.node.yaml then

@pscheit pscheit force-pushed the use-node-in-docker branch from f0e9c0e to 3b751f1 Compare March 11, 2024 12:49
@pscheit pscheit force-pushed the use-node-in-docker branch from 3b751f1 to 61722d5 Compare March 11, 2024 13:14
README.md Outdated Show resolved Hide resolved
@Seldaek Seldaek merged commit 8736822 into composer:main Mar 12, 2024
3 checks passed
@Seldaek
Copy link
Member

Seldaek commented Mar 12, 2024

Alright thanks

@pscheit pscheit deleted the use-node-in-docker branch March 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants