-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger error on unsafe StrictGroups usages #29
Conversation
@staabm if you have a sec to review my Rule 🙏🏻 but it seems to work well. I'll try it on the composer repo now see if it catches anything. |
I think it looks really good already. good job! I would separate the type-expectations which require phpstan/phpstan-src#3229 into a separate PR, because ondrey seems to be on holiday and the PR might need a few days before getting merged |
It still fails on 7.2/7.3 but that would require my other PR with the override to fix.. |
awesome |
wdyt about marking |
Yes why not i guess. Will do later |
Changed my mind about deprecation, calling isMatch when you don't really check the return value looks/reads weird so I'd rather not force that. |
Depends on phpstan/phpstan-src#3229