Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add json-repair to handle invalid json resp #39

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

shfc
Copy link
Collaborator

@shfc shfc commented Oct 18, 2024

Description

This issue is mainly caused by the invalid escape \o in the response JSON data.
Test example: https://courseplanner.uni.adelaide.edu.au/course/1-2024-109708-4410

Changes Made

  • Add a json-repair package to repair the json data
  • Check the course_details structure before processing courses to be more robust

Related Issues

Fixes #38

Additional Notes

image

@shfc shfc requested review from rayokamoto, jsun969 and phoenixpereira and removed request for rayokamoto and jsun969 October 18, 2024 07:24
@shfc shfc changed the title Fix/invalid json resp fix: Add json-repair to handle invalid json resp Oct 18, 2024
@phoenixpereira phoenixpereira added the enhancement New feature or request label Oct 18, 2024
@phoenixpereira phoenixpereira merged commit 5811c21 into compsci-adl:main Oct 19, 2024
2 checks passed
@shfc shfc deleted the fix/invalid-json-resp branch October 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Specific Course Throwing Error And Terminating Script
4 participants