export some of the shader loading functionality #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, might have made this a bit prematurely. i wanted to pass the shader loader into the preprocessor so it can load includes as well. |
pwfff
force-pushed
the
pwf/shader-loader
branch
from
43817e5
to
3ece481
Compare
|
yeah, passing the loader in to the preprocessor is nice, but it's rough to do for the wasm target since i'm trying to do this as a sync trait... |
pwfff
force-pushed
the
pwf/shader-loader
branch
from
3ece481
to
6b6a663
Compare
davidar
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Sorry for the delay, I haven't tested it yet but mostly looks good, I just wanted to check that removing std/ hasn't broken some of the include paths (the idea is that #include <string> goes to std/string.wgsl, though I suppose we could simplify that and just remove the std directory)
| @@ -144,7 +141,7 @@ impl Preprocessor { | |||
| if path == "string" { | |||
| self.enable_strings = true; | |||
| } | |||
| fetch_include(format!("std/{path}")).await | |||
| fetch_include(path.to_string()).await | |||
There was a problem hiding this comment.
Any reason for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.