Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce link checker #54

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Introduce link checker #54

merged 3 commits into from
Oct 21, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Oct 17, 2024

No description provided.

@asmacdo
Copy link
Member Author

asmacdo commented Oct 17, 2024

@yarikoptic could you check if "Run workflows from fork pull requests" is enabled under Settings → Actions → General.

@yarikoptic
Copy link
Member

I do not see such exact wording there. Made you admin so hopefully you could get to that interface yourself, can you?

@asmacdo asmacdo marked this pull request as ready for review October 21, 2024 15:11
@asmacdo asmacdo closed this Oct 21, 2024
@asmacdo asmacdo reopened this Oct 21, 2024
@asmacdo asmacdo closed this Oct 21, 2024
@asmacdo asmacdo reopened this Oct 21, 2024
@asmacdo
Copy link
Member Author

asmacdo commented Oct 21, 2024

I opened another PR from non-fork and suddenly this one started working 🤷

@asmacdo
Copy link
Member Author

asmacdo commented Oct 21, 2024

@yarikoptic AFAICT there is no way to get the linkchecker to ignore the malformed email addresses. (which are malformed deliberately to avoid spam).

Even when we --ignore-url, it still checks the syntax and fails.

URL        `mailto:mvdm at dartmouth dot edu'
Name       `E-Mail'
Parent URL file:///home/austin/devel/centerforopenneuroscience.org/output/whoweare.html, line 374, col 9
Real URL   mailto:mvdm%20at%20dartmouth%20dot%20edu
Info       The URL is outside of the domain filter, checked only
           syntax.
Result     Error: Missing `@' in mail address `mvdm'.

Option 1: fix email addr
Option 2: remove email address button
Option 3: try another tool

@yarikoptic
Copy link
Member

Could you check/ file ticket for link checker?

@asmacdo
Copy link
Member Author

asmacdo commented Oct 21, 2024

This allows some stealthy contributors to avoid spam with addresses like:
   myemail at somewhere dot edu
@asmacdo
Copy link
Member Author

asmacdo commented Oct 21, 2024

@yarikoptic got it. ready for review

@yarikoptic
Copy link
Member

Great, thank you! I will deploy later

@yarikoptic yarikoptic merged commit 876f02b into con:master Oct 21, 2024
1 check passed
@asmacdo asmacdo deleted the add-link-checker branch October 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants