xz_utils: conan v2 support

[SpaceIm]

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[SpaceIm]

upgrade_project logic is lost in this conan v2 migration, I don't know what is the equivalent in the new MSBuild build helper.

[SpaceIm]

and it's required, it fails on Windows with Visual Studio 2022

[SpaceIm]

conan-io/conan#12155

[SpaceIm]

@memsharded could you confirm this is the canonical way to conditionally enable win_bash in conan v2 methods (for this case it's for MinGW, and we ensure that a bash is available on windows build machine by adding msys2 recipe to tool_requires if user did not define tools.microsoft.bash:path in its conan configuration)?

[SpaceIm]

I've tested locally on windows with MinGW. It works... almost:

It fails during installation because install path is not converted to unix path:

 /usr/bin/install -c -m 644  /c/users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/src/src/liblzma/api/lzma.h 'C:Usersspaceim.conandataxz_utils5.2.5__package3cbc13750c61092b2c900ee6caef68cf1cd320b4/include/.'
make[4]: Leaving directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma/api'
make[3]: Leaving directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma/api'
make[3]: Entering directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma'
make[4]: Entering directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma'
 /usr/bin/mkdir -p 'C:Usersspaceim.conandataxz_utils5.2.5__package3cbc13750c61092b2c900ee6caef68cf1cd320b4/lib'
 /usr/bin/mkdir -p 'C:Usersspaceim.conandataxz_utils5.2.5__package3cbc13750c61092b2c900ee6caef68cf1cd320b4/lib/pkgconfig'
 /bin/sh ../../libtool   --mode=install /usr/bin/install -c   liblzma.la 'C:Usersspaceim.conandataxz_utils5.2.5__package3cbc13750c61092b2c900ee6caef68cf1cd320b4/lib'
 /usr/bin/install -c -m 644 liblzma.pc 'C:Usersspaceim.conandataxz_utils5.2.5__package3cbc13750c61092b2c900ee6caef68cf1cd320b4/lib/pkgconfig'
Usage: /c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/libtool [OPTION]... [MODE-ARG]...
Try 'libtool --help' for more information.
libtool:   error: 'C:Usersspaceim.conandataxz_utils5.2.5__package3cbc13750c61092b2c900ee6caef68cf1cd320b4/lib' must be an absolute directory name
make[4]: *** [Makefile:876: install-libLTLIBRARIES] Error 1
make[4]: Leaving directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma'
make[3]: *** [Makefile:1802: install-am] Error 2
make[3]: Leaving directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma'
make[2]: *** [Makefile:1638: install-recursive] Error 1
make[2]: Leaving directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src/liblzma'
make[1]: *** [Makefile:422: install-recursive] Error 1
make[1]: Leaving directory '/c/Users/spaceim/.conan/data/xz_utils/5.2.5/_/_/build/3cbc13750c61092b2c900ee6caef68cf1cd320b4/build-release/src'
make: *** [Makefile:616: install-recursive] Error 1

[SpaceIm]

here: https://github.com/conan-io/conan/blob/1.52.0/conan/tools/gnu/autotools.py#L58

[SpaceIm]

That's it. If I replace autotools.install() by autotools.install(args=[f"DESTDIR={unix_path(self, self.package_folder)}"]), it works (note: if I call conan create -kb it fails with ConanException: The config 'tools.microsoft.bash:subsystem' is needed to run commands in a Windows subsystem, funny since this config is injected by msys2 recipe)

[SpaceIm]

Here we go: conan-io/conan#12153 & conan-io/conan#12154

[uilianries]

@SpaceIm Thank you very much for checking it. The new MSBuild is still limited in terms of features, compared to the legacy.

[SpaceIm]

Error: recipes/xz_utils/all/conanfile.py:107: [E1123(unexpected-keyword-arg), XZUtils._build_msvc] Unexpected keyword argument 'targets' in method call

Ok, it requires conan >= 1.52.0 :( conan-io/conan#11968

[ghost]

I detected other pull requests that are modifying xz_utils/all recipe:

• [xz_utils] Add version 5.2.6 + Update imports + Add mirror #12308

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[SpaceIm]

LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\xz_utils\all\test_v1_package\build\7f904f5e60fd8354a86d19e62c1e7c493d74cd43\test_package.vcxproj]
lzma.lib(common.obj) : warning LNK4217: locally defined symbol free imported in function lzma_free [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\xz_utils\all\test_v1_package\build\7f904f5e60fd8354a86d19e62c1e7c493d74cd43\test_package.vcxproj]
lzma.lib(common.obj) : warning LNK4217: locally defined symbol malloc imported in function lzma_alloc [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\xz_utils\all\test_v1_package\build\7f904f5e60fd8354a86d19e62c1e7c493d74cd43\test_package.vcxproj]
lzma.lib(common.obj) : error LNK2019: unresolved external symbol __imp_calloc referenced in function lzma_alloc_zero [C:\J\w\prod\BuildSingleReference@2\conan-center-index\recipes\xz_utils\all\test_v1_package\build\7f904f5e60fd8354a86d19e62c1e7c493d74cd43\test_package.vcxproj]

Ok so the build of xz_utils didn't honor MTd runtime, and it fails afterwards in test_package due to runtime discrepancy.

In sln & vcxproj files of xz_utils, there is no DebugMTd config (only ReleaseMT, ReleaseMD, DebugMDd). I'm not familiar enough with MSBuild files internal mechanism, so I'm not sure how to fix this issue so that props file generated by MSBuildToolchain works in a robust way against sln & vcxproj files of xz_utils. All I know is that it was working with legacy MSBuild.

/cc @memsharded

Actually it's not honored also in MT static build (https://c3i.jfrog.io/c3i/misc/logs/pr/13038/10-configs/windows-visual_studio/xz_utils/5.2.5//7bd6f2c3d5c4e48a75805376b58cde753392f711-test.txt):

  Checking Build System
  Building Custom Rule C:/J/w/prod/BuildSingleReference/conan-center-index/recipes/xz_utils/all/test_package/CMakeLists.txt
  test_package.c
LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\xz_utils\all\test_package\build\test_package.vcxproj]
lzma.lib(common.obj) : warning LNK4217: locally defined symbol calloc imported in function lzma_alloc_zero [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\xz_utils\all\test_package\build\test_package.vcxproj]
lzma.lib(common.obj) : warning LNK4217: locally defined symbol free imported in function lzma_end [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\xz_utils\all\test_package\build\test_package.vcxproj]
lzma.lib(common.obj) : warning LNK4217: locally defined symbol malloc imported in function lzma_alloc [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\xz_utils\all\test_package\build\test_package.vcxproj]
  test_package.vcxproj -> C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\xz_utils\all\test_package\build\Release\test_package.exe
  Building Custom Rule C:/J/w/prod/BuildSingleReference/conan-center-index/recipes/xz_utils/all/test_package/CMakeLists.txt
xz_utils/5.2.5 (test package): Running test()

[SpaceIm]

It should work now (even MinGW). Honestly I'm not very proud of all these MSBuild tricks. There are currently 27 recipes in conan-center relying on legacy MSBuild. If anybody has something more robust to propose (inject conantoolchain.props from MSBuildToolchain, avoid conflicts, honor custom clflags, cxxflags, ldflags from profile etc), please share !

Note: on macos if shared, install_name of dependencies in executables are not correct (see conan-io/conan#12107). But since PATH was not populated, I guess nobody was using them.

[conan-center-bot]

All green in build 14 (45b063657d14323c8a87dcf0cdca5b91f403bb3d):

• xz_utils/5.2.5@:
  All packages built successfully! (All logs)

• xz_utils/5.2.4@:
  All packages built successfully! (All logs)