Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu: modernize more for conan v2 #15778

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 6, 2023

There is still a legacy function: get_gnu_triplet(). See conan-io/conan#13028


- use new stdcpp_library() instead of legacy one (since conan 1.54.0)
- write custom _sha256sum() function to avoid relying on legacy conans.tools.sha256sum() conan function
- remove workaround for conan-io/conan#12642 (fixed in conan 1.57.0)
- remove workaround for conan-io/conan#12153 (fixed in conan 1.54.0)
@ghost
Copy link

ghost commented Feb 6, 2023

I detected other pull requests that are modifying icu/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Feb 6, 2023
4 tasks
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Feb 6, 2023
@SpaceIm SpaceIm reopened this Feb 6, 2023
@SpaceIm SpaceIm closed this Feb 6, 2023
@SpaceIm SpaceIm reopened this Feb 6, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (8a8697a8b23322c1ca56bd2d4468775246cc51f6):

  • icu/72.1@:
    All packages built successfully! (All logs)

  • icu/69.1@:
    All packages built successfully! (All logs)

  • icu/70.1@:
    All packages built successfully! (All logs)

  • icu/66.1@:
    All packages built successfully! (All logs)

  • icu/65.1@:
    All packages built successfully! (All logs)

  • icu/68.2@:
    All packages built successfully! (All logs)

  • icu/71.1@:
    All packages built successfully! (All logs)

  • icu/67.1@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 6 (8a8697a8b23322c1ca56bd2d4468775246cc51f6):

  • icu/72.1@:
    Error running command conan export --name icu --version 72.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/70.1@:
    Error running command conan export --name icu --version 70.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/71.1@:
    Error running command conan export --name icu --version 71.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/69.1@:
    Error running command conan export --name icu --version 69.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/68.2@:
    Error running command conan export --name icu --version 68.2 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/67.1@:
    Error running command conan export --name icu --version 67.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/66.1@:
    Error running command conan export --name icu --version 66.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    
  • icu/65.1@:
    Error running command conan export --name icu --version 65.1 recipes/icu/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15778/recipes/icu/all/conanfile.py", line 10, in <module>
        from conans.tools import get_gnu_triplet
    ModuleNotFoundError: No module named 'conans.tools'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot conan-center-bot merged commit a053fb6 into conan-io:master Feb 7, 2023
@SpaceIm SpaceIm deleted the icu-modernize-more branch February 7, 2023 20:14
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
- use new stdcpp_library() instead of legacy one (since conan 1.54.0)
- write custom _sha256sum() function to avoid relying on legacy conans.tools.sha256sum() conan function
- remove workaround for conan-io/conan#12642 (fixed in conan 1.57.0)
- remove workaround for conan-io/conan#12153 (fixed in conan 1.54.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants