-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH Runner: Fix several issues and refactor code #17357
Open
perseoGI
wants to merge
11
commits into
conan-io:develop2
Choose a base branch
from
perseoGI:pgi/ssh-runner
base: develop2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perseoGI
force-pushed
the
pgi/ssh-runner
branch
from
November 25, 2024 10:04
cf0893c
to
6c7b1b8
Compare
memsharded
reviewed
Dec 18, 2024
def __init__(self, conan_api, command, host_profile, build_profile, args, raw_args): | ||
from paramiko.config import SSHConfig | ||
from paramiko.client import SSHClient | ||
def __init__( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid formatting and typing changes, it makes difficult to read the changelog and check if some new argument was added to the constructor
perseoGI
commented
Dec 18, 2024
perseoGI
force-pushed
the
pgi/ssh-runner
branch
from
December 27, 2024 10:26
ff37095
to
5032b3c
Compare
perseoGI
force-pushed
the
pgi/ssh-runner
branch
from
January 28, 2025 10:16
5032b3c
to
2c65bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Introducing
SSH runner
Docs: conan-io/docs#3972
Changes:
jinja2
templates intact to allow remote runner to render them locallybuild
recipes. Solved by always exporting all the packages and forcing a local cache refresh&
and*
during ssh remote invoquesconan config list
runner.ssh
keydevelop
branch, documenting this one.