Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Wrong prefix for AutotoolsToolchain (or wrong docs) #2795

Closed
dubvulture opened this issue Sep 1, 2022 · 6 comments
Closed

[bug] Wrong prefix for AutotoolsToolchain (or wrong docs) #2795

dubvulture opened this issue Sep 1, 2022 · 6 comments
Assignees
Milestone

Comments

@dubvulture
Copy link

The documentation for AutotoolsToolchain states that:

  • configure_args: Additional arguments to be passed to the configure script.
    • By default the following arguments are passed:
      • --prefix: With the self.package_folder value.

But the code seems to default to /, see here.
This was changed in conan-io/conan#11284, before that it was set as stated in the documentation.

@jellespijker
Copy link

The autotools.install() method is also not aware of the subsystem. When using the msys2 recipe as a tool_requires you need to add the following line to the recipe.

autotools.install(args=[f"DESTDIR={unix_path(self, self.package_folder)}"])

where unix_path is imported from conan.tools.microsoft

@planetmarshall
Copy link

If you set --prefix=self.package_folder, then the absolute path of the package folder is appended to the package folder again, so for example if the package folder is /home/conan/.conan/data/package, the package will end up being installed in /home/conan/.conan/data/package/home/conan/.conan/data/package

@samuel-emrys
Copy link

Looks like this was changed in conan-io/conan#11264. Also related: conan-io/conan#12338

Documentation needs to be updated to reflect the change in approach.

// cc @czoido as the author of the changes

@czoido czoido self-assigned this Nov 2, 2022
@czoido
Copy link
Contributor

czoido commented Nov 2, 2022

Thanks for reporting @dubvulture,
The documentation is indeed wrong, we'll fix it, I'm transferring this to the docs repo.
@jellespijker Regarding the problem with Windows there's a PR open: conan-io/conan#12193 there are some tests pending but we will try to push it for the next release.

@czoido czoido transferred this issue from conan-io/conan Nov 2, 2022
@czoido czoido added this to the 1.54 milestone Nov 2, 2022
@jellespijker
Copy link

Thanks for reporting @dubvulture, The documentation is indeed wrong, we'll fix it, I'm transferring this to the docs repo. @jellespijker Regarding the problem with Windows there's a PR open: conan-io/conan#12193 there are some tests pending but we will try to push it for the next release.

that is excellent news 👍

@czoido
Copy link
Contributor

czoido commented Nov 4, 2022

Closed by #2800

@czoido czoido closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants