-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autotools install on Windows #12193
Fix autotools install on Windows #12193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking good, but we would need a test that fails without this fix.
There are subsystems like msys2 installed in our CI, it should be possible, look for pytest.mark.tool_msys2
or something like that, or ask for help if you need it, and we can try to contribute a test
Yes. I guess https://github.com/conan-io/conan/blob/4cfd5af2f6e1ead79ce173aebf61b50dbe440a81/conans/test/functional/toolchains/gnu/autotools/test_win_bash.py could be a good source of inspiration. Actually it could be extended since it already test AutotoolsToolchain & Autotools build on Windows, but without going until installation. |
Need some help here, I can't reproduce this issue on Windows in the test when I remove the fix. |
Changelog: Bugfix: Fix Autotools install on Windows. The default argument passed is
DESTDIR=unix_path(self, self.package_folder)
.Docs: conan-io/docs#2801
Closes #12153
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.