-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check python environment #49
Conversation
python main.py | ||
pip install protobuf | ||
python ../main.py | ||
pip uninstall -y protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to make it work with a virtualenv 😢 , so I use the main python environment and uninstall the new package afterward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protobuf is evil 😈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you remove all python package installed by protobuf as last step? So I think is possible to use with virtualenv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem with the virtualenv is that I'm not able to install protobuf
inside the virtualenv in Linux (like I do in Windows or Mac), and to pass this new check (--- tests do not modify the python environment ---) I need to remove it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows has failed too 😢 ...so it is something related to the levels of bash calling bash calling python calling bash... so I've moved to the uninstall
strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it is good enough at the moment
I wrote my concerns about this example in #50 |
protobuf
one was installingprotobuf
libraries which upgradedsix
package to a version not compatible with Conanprotobuf
example: if we need to install Python stuff, use a virtualenv