Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check python environment #49

Merged
merged 19 commits into from
Feb 10, 2020
Merged

Check python environment #49

merged 19 commits into from
Feb 10, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Feb 7, 2020

  • Check a test is not modifying python dependencies: protobuf one was installing protobuf libraries which upgraded six package to a version not compatible with Conan
  • Fix protobuf example: if we need to install Python stuff, use a virtualenv

@jgsogo jgsogo self-assigned this Feb 7, 2020
python main.py
pip install protobuf
python ../main.py
pip uninstall -y protobuf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to make it work with a virtualenv 😢 , so I use the main python environment and uninstall the new package afterward

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf is evil 😈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you remove all python package installed by protobuf as last step? So I think is possible to use with virtualenv

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with the virtualenv is that I'm not able to install protobuf inside the virtualenv in Linux (like I do in Windows or Mac), and to pass this new check (--- tests do not modify the python environment ---) I need to remove it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows has failed too 😢 ...so it is something related to the levels of bash calling bash calling python calling bash... so I've moved to the uninstall strategy

Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it is good enough at the moment

@jgsogo
Copy link
Contributor Author

jgsogo commented Feb 10, 2020

I wrote my concerns about this example in #50

@jgsogo jgsogo merged commit 29cdcc8 into conan-io:master Feb 10, 2020
@jgsogo jgsogo deleted the protobuf/venv branch February 10, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants