Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'if' syntax error in bat. #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhangyiant
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 6, 2021

CLA assistant check
All committers have signed the CLA.

@memsharded
Copy link
Member

Thanks for contributing. The CI has an error, doesn't seem related to your PR.

FYI, the workspace is a experimental feature that has been on hold for a long time, as we are working in other priorities, so there will be rough edges and expect partial functionality.

Can you clarify if this change is necessary, was it really broken or it is just style?

@zhangyiant
Copy link
Author

Thanks for contributing. The CI has an error, doesn't seem related to your PR.

FYI, the workspace is a experimental feature that has been on hold for a long time, as we are working in other priorities, so there will be rough edges and expect partial functionality.

Can you clarify if this change is necessary, was it really broken or it is just style?

It's really broken. The "else" in build.bat cannot work if it's on a separate line, but the script will continue to run. So it has almost no impact. Anyway, it's a bug in the script, so fix it incidentally.

@czoido
Copy link
Contributor

czoido commented May 6, 2021

@memsharded, @zhangyiant
I have just fixed the CI error for the MacOs node, looks like the CI it's working now again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants