Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doil_into_container dic_335 add php container to handle doil commands #343

Merged

Conversation

daniwe4
Copy link
Member

@daniwe4 daniwe4 commented Jul 11, 2023

No description provided.

@daniwe4 daniwe4 added improvement New feature or request review labels Jul 11, 2023
@daniwe4 daniwe4 added this to the Doil-Into-Container milestone Jul 11, 2023
@daniwe4 daniwe4 linked an issue Jul 11, 2023 that may be closed by this pull request
@daniwe4 daniwe4 force-pushed the dic_335 branch 2 times, most recently from 4136185 to 109e6ec Compare July 11, 2023 09:55
Copy link
Contributor

@tbongers-cat tbongers-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, looking forward to using it =)
I have some small changes/questions and some annotations on translations/expressions (as you probably expected).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
setup/system.sh Show resolved Hide resolved
setup/doil.sh Show resolved Hide resolved
app/src/Lib/FileSystem/Filesystem.php Outdated Show resolved Hide resolved
app/src/Commands/Instances/DeleteCommand.php Show resolved Hide resolved
app/src/Commands/System/UninstallCommand.php Outdated Show resolved Hide resolved
Copy link
Contributor

@tbongers-cat tbongers-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve!

@tbongers-cat tbongers-cat merged commit 97ca82d into conceptsandtraining:doil_into_container Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move doil into its own container
2 participants