-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally download tags when getting object #142
Conversation
* Writes the tags to a file called `tags.json` Signed-off-by: Mark DeLillo <[email protected]>
Signed-off-by: Mark DeLillo <[email protected]>
363d76a
to
7b1ba3b
Compare
Hi @mdelillo , it seems there is test failure on both alpine and ubuntu build.
|
From the error it seems like the S3 token doesn't have permission to write object tags. I actually ended up solving my original problem in a different way, so if this isn't easily mergeable then I'll probably close it out. |
I have config the IAM to have right permissions for the tests it looks good now. Will try to move this PR forward. |
@mdelillo all looks good. The only concern is the IAM change that needed for using |
That makes sense, I added it to Required IAM Permissions. I also added a section in the integration tests since the |
Signed-off-by: Mark DeLillo <[email protected]>
This adds a new param to
in
requests calleddownload_tags
. It will write the S3 object tags as key:value pairs totags.json
. It is disabled by default.The
SetTags
function ons3client
is currently only used for testing, but it could be used to allow tags to be written inout
(#119).