adduser.8/files: link real logfile #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: 280538 MFC after: 3 days Reported by: Herbert Baerschneider <[email protected]>
concussious
pushed a commit
that referenced
this pull request
Nov 12, 2024
Avoid calling _callout_stop_safe with a non-sleepable lock held when
detaching by initializing callout_init_rw() with CALLOUT_SHAREDLOCK.
It avoids the following WITNESS warning when stopping the service:
# service ipfilter stop
calling _callout_stop_safe with the following non-sleepable locks held:
shared rw ipf filter load/unload mutex (ipf filter load/unload mutex) r = 0 (0xffff0000417c7530) locked @ /usr/src/sys/netpfil/ipfilter/netinet/fil.c:7926
stack backtrace:
#0 0xffff00000052d394 at witness_debugger+0x60
#1 0xffff00000052e620 at witness_warn+0x404
freebsd#2 0xffff0000004d4ffc at _callout_stop_safe+0x8c
freebsd#3 0xffff0000f7236674 at ipfdetach+0x3c
freebsd#4 0xffff0000f723fa4c at ipf_ipf_ioctl+0x788
freebsd#5 0xffff0000f72367e0 at ipfioctl+0x144
freebsd#6 0xffff00000034abd8 at devfs_ioctl+0x100
freebsd#7 0xffff0000005c66a0 at vn_ioctl+0xbc
freebsd#8 0xffff00000034b2cc at devfs_ioctl_f+0x24
freebsd#9 0xffff0000005331ec at kern_ioctl+0x2e0
freebsd#10 0xffff000000532eb4 at sys_ioctl+0x140
freebsd#11 0xffff000000880480 at do_el0_sync+0x604
freebsd#12 0xffff0000008579ac at handle_el0_sync+0x4c
PR: 282478
Suggested by: markj
Reviewed by: cy
Approved by: emaste (mentor)
MFC after: 1 week
concussious
pushed a commit
that referenced
this pull request
Dec 13, 2024
Switch from creating the msr instructions to manage PAN to use the "msr pan, #1" instruction directly. When this was added clang didn't have support to assemble the instructions. This appears to have been added to clang 13 which is sufficiently old enough. Binutils releases from around the same time appear to have added this instruction so any modern gcc should also support this instruction. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D47817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: 280538
MFC after: 3 days
Reported by: Herbert Baerschneider [email protected]