Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.15.2 #14

Merged
merged 34 commits into from
Jan 10, 2023
Merged

Bump to 3.15.2 #14

merged 34 commits into from
Jan 10, 2023

Conversation

hadim
Copy link
Member

@hadim hadim commented Jan 3, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Jan 3, 2023

The CI will fail because of missing deps.

@hadim
Copy link
Member Author

hadim commented Jan 3, 2023

Blocked by:

@hadim hadim mentioned this pull request Jan 3, 2023
10 tasks
@gorarakelyan
Copy link
Member

@hadim thanks for the contribution! This is huge!! Please feel free to let me know if you need any help.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Jan 10, 2023

The python 3.10 builds are blocked by conda-forge/restrictedpython-feedstock#6

@hadim
Copy link
Member Author

hadim commented Jan 10, 2023

@gorarakelyan: we are quite close here. We only need this conda-forge/restrictedpython-feedstock#6 to be merged and this PR should be good to go.

Windows builds are not available because of aimrocks (aimhubio/aimrocks#22). Once available, the rocksdb conda forge package will need to be built against windows as well (I don't think I'll have time to build windows packages since I don't use them myself).

@hadim
Copy link
Member Author

hadim commented Jan 10, 2023

@gorarakelyan: I am skipping python 3.10 for now and will trigger a new build whenever conda-forge/restrictedpython-feedstock#6 is merged.

You can merge here!

Copy link
Member

@gorarakelyan gorarakelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hadim

This comment was marked as outdated.

@gorarakelyan
Copy link
Member

@hadim I will merge the PR now and open respective issues for:

  • support for python later versions
  • windows support

@gorarakelyan gorarakelyan merged commit 92f8ea6 into conda-forge:main Jan 10, 2023
@hadim hadim deleted the bump_3.15.2 branch January 10, 2023 22:46
This was referenced Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants