Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update historic tpot pins against python, numpy #673

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Update historic tpot pins against python, numpy #673

merged 4 commits into from
Feb 27, 2024

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 26, 2024 •
edited
Loading

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

References:

Notes:

  • fixing the python and numpy pins is enough to get import tpot to run (and the test suite to start) back to 0.11.2
    • at the far end of the noarch: python epoch, the tests fail, but many packages don't even have test suites in conda-forge, so I'm not going to do the larger matrix sweep to pin everything to get those to work

Changes:

================================================================================
================================================================================
win-32
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
linux-ppc64le
================================================================================
================================================================================
osx-arm64
================================================================================
================================================================================
linux-aarch64
================================================================================
================================================================================
noarch
noarch::tpot-0.11.6.post1-pyhd3deb0d_0.tar.bz2
noarch::tpot-0.11.5-pyh9f0ad1d_0.tar.bz2
noarch::tpot-0.11.2-pyh9f0ad1d_0.tar.bz2
noarch::tpot-0.11.6-pyh9f0ad1d_0.tar.bz2
noarch::tpot-0.11.6.post3-pyhd3deb0d_0.tar.bz2
noarch::tpot-0.11.6.post2-pyhd3deb0d_1.tar.bz2
noarch::tpot-0.11.7-pyhd8ed1ab_1.tar.bz2
noarch::tpot-0.11.3-pyh9f0ad1d_0.tar.bz2
-    "numpy >=1.16.3",
+    "numpy >=1.16.3,<1.20.0a0",
-    "python >=3.5",
+    "python >=3.5,<3.12.0a0",
noarch::tpot-0.12.0-pyhd8ed1ab_0.conda
noarch::tpot-0.12.1-pyhd8ed1ab_0.conda
-    "python >=3.5",
+    "python >=3.5,<3.12.0a0",
================================================================================
================================================================================
osx-64
================================================================================
================================================================================
linux-64

anaconda.org then started sending 524s), will validate against what the PR says

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl bollwyvl mentioned this pull request Feb 26, 2024
Closed
1 task
@bollwyvl
Copy link
Contributor Author

From CI:

2024-02-26T22:40:19.2262002Z patching repodata:   0%|          | 0/9 [00:00<?, ?it/s]/home/conda/feedstock_root/build_artifacts/conda-forge-repodata-patches_1708986863797/work/gen_patch_json.py:953: DeprecationWarning: conda_build.index._apply_instructions is deprecated and will be removed in 24.5.0. Use `conda_index._apply_instructions` instead.
2024-02-26T22:40:19.2270619Z   new_repodata = _apply_instructions(subdir, repodata, instructions)
2024-02-26T22:40:20.9295641Z 
2024-02-26T22:40:20.9344152Z patching repodata:  11%|█         | 1/9 [03:14<25:59, 194.91s/it]
2024-02-26T22:40:20.9345043Z ================================================================================
2024-02-26T22:40:20.9345433Z ================================================================================
2024-02-26T22:40:20.9345706Z noarch
2024-02-26T22:40:20.9346070Z noarch::tpot-0.11.3-pyh9f0ad1d_0.tar.bz2
2024-02-26T22:40:20.9346418Z noarch::tpot-0.11.6-pyh9f0ad1d_0.tar.bz2
2024-02-26T22:40:20.9346767Z noarch::tpot-0.11.5-pyh9f0ad1d_0.tar.bz2
2024-02-26T22:40:20.9347118Z noarch::tpot-0.11.6.post3-pyhd3deb0d_0.tar.bz2
2024-02-26T22:40:20.9347472Z noarch::tpot-0.11.7-pyhd8ed1ab_1.tar.bz2
2024-02-26T22:40:20.9347804Z noarch::tpot-0.11.2-pyh9f0ad1d_0.tar.bz2
2024-02-26T22:40:20.9348160Z noarch::tpot-0.11.6.post2-pyhd3deb0d_1.tar.bz2
2024-02-26T22:40:20.9348520Z noarch::tpot-0.11.6.post1-pyhd3deb0d_0.tar.bz2
2024-02-26T22:40:20.9348846Z -    "numpy >=1.16.3",
2024-02-26T22:40:20.9349149Z +    "numpy >=1.16.3,<1.20.0a0",
2024-02-26T22:40:20.9349443Z -    "python >=3.5",
2024-02-26T22:40:20.9349690Z +    "python >=3.5,<3.12.0a0",
2024-02-26T22:40:20.9447896Z noarch::tpot-0.12.1-pyhd8ed1ab_0.conda
2024-02-26T22:40:20.9450108Z noarch::tpot-0.12.0-pyhd8ed1ab_0.conda
2024-02-26T22:40:20.9451414Z -    "python >=3.5",
2024-02-26T22:40:20.9452568Z +    "python >=3.5,<3.12.0a0",
2024-02-26T22:40:20.9453605Z 
2024-02-26T22:40:21.9333013Z 
2024-02-26T22:40:21.9335380Z patching repodata:  22%|██▏       | 2/9 [03:15<09:25, 80.85s/it] 
2024-02-26T22:40:21.9336188Z ================================================================================
2024-02-26T22:40:21.9547020Z ================================================================================
2024-02-26T22:40:21.9550588Z linux-armv7l
2024-02-26T22:40:21.9550797Z 
2024-02-26T22:42:51.9854273Z 
2024-02-26T22:42:51.9856506Z patching repodata:  33%|███▎      | 3/9 [05:45<11:14, 112.45s/it]
2024-02-26T22:42:51.9859353Z ================================================================================
2024-02-26T22:42:51.9860042Z ================================================================================
2024-02-26T22:42:51.9860531Z linux-aarch64
2024-02-26T22:42:51.9860773Z 
2024-02-26T22:45:03.7666478Z 
2024-02-26T22:45:03.7675506Z patching repodata:  44%|████▍     | 4/9 [07:57<10:00, 120.08s/it]
2024-02-26T22:45:03.7676094Z ================================================================================
2024-02-26T22:45:03.7680511Z ================================================================================
2024-02-26T22:45:03.7733155Z linux-ppc64le
2024-02-26T22:45:03.7733746Z 
2024-02-26T22:45:16.7534434Z /home/conda/feedstock_root/build_artifacts/conda-forge-repodata-patches_1708986863797/work/gen_patch_json.py:953: DeprecationWarning: conda_build.index._apply_instructions is deprecated and will be removed in 24.5.0. Use `conda_index._apply_instructions` instead.
2024-02-26T22:45:16.7536872Z   new_repodata = _apply_instructions(subdir, repodata, instructions)
2024-02-26T22:45:25.0321124Z 
2024-02-26T22:45:25.0322238Z ================================================================================
2024-02-26T22:45:25.0324941Z ================================================================================
2024-02-26T22:45:25.0331165Z linux-64
2024-02-26T22:45:25.0333519Z 
2024-02-26T22:45:25.0337336Z 
2024-02-26T22:47:22.3450533Z patching repodata:  56%|█████▌    | 5/9 [08:19<05:37, 84.45s/it] 
2024-02-26T22:47:22.3451902Z patching repodata:  67%|██████▋   | 6/9 [10:16<04:46, 95.62s/it]
2024-02-26T22:47:22.3452676Z ================================================================================
2024-02-26T22:47:22.3453135Z ================================================================================
2024-02-26T22:47:22.3453796Z osx-arm64
2024-02-26T22:47:22.3454197Z 
2024-02-26T22:47:47.6003202Z 
2024-02-26T22:47:47.6009343Z patching repodata:  78%|███████▊  | 7/9 [10:41<02:25, 72.62s/it]
2024-02-26T22:47:47.6016712Z ================================================================================
2024-02-26T22:47:47.6017389Z ================================================================================
2024-02-26T22:47:47.6017765Z win-32
2024-02-26T22:47:47.6018010Z 
2024-02-26T22:52:09.2660731Z 
2024-02-26T22:52:09.2661426Z 
2024-02-26T22:52:09.2662332Z patching repodata:  89%|████████▉ | 8/9 [15:03<02:12, 132.80s/it]================================================================================
2024-02-26T22:52:09.2662718Z ================================================================================
2024-02-26T22:52:09.2662963Z osx-64
2024-02-26T22:52:09.2663073Z 
2024-02-26T22:52:58.7695426Z 
2024-02-26T22:52:58.7697748Z patching repodata: 100%|██████████| 9/9 [15:52<00:00, 106.76s/it]
2024-02-26T22:52:58.7712052Z patching repodata: 100%|██████████| 9/9 [15:52<00:00, 105.86s/it]
2024-02-26T22:52:58.7715705Z 
2024-02-26T22:52:58.7716499Z ================================================================================
2024-02-26T22:52:58.7790503Z ================================================================================
2024-02-26T22:52:58.7791015Z win-64
2024-02-26T22:52:58.7791171Z 
2024-02-26T22:53:00.0340843Z

@bollwyvl bollwyvl marked this pull request as ready for review February 26, 2024 22:59
@bollwyvl bollwyvl requested a review from a team as a code owner February 26, 2024 22:59
@bollwyvl
Copy link
Contributor Author

@conda-forge/conda-forge-repodata-patches ready for review

jakirkham
jakirkham reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick! 🙏

Had a question below

recipe/patch_yaml/tpot.yaml Outdated
# - https://github.com/conda-forge/tpot-feedstock/pull/21
if:
name: tpot
version_ge: 0.11.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 0.11.0 & 0.11.1 were noarch as well. Should we include them too?

Suggested change
version_ge: 0.11.2
version_ge: 0.11.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check if that blends against py3.11...

@bollwyvl
Copy link
Contributor Author

Ok, updated with links to noarch PR, and tweaked the scikit-learn top pin for the oldest one.

0.11.0 imports, but there are some broken things around xgboost and dask... as those are optional dependencies, I don't see it being worth digging around too much further. Also have to step away for a while, so will pick this back up tomorrow... any other contributions welcome!

@jakirkham
Copy link
Member

At least in terms of the original goal of making sure tpot doesn't install with Python 3.12 for versions that don't support it ( conda-forge/tpot-feedstock#39 ), think this is sufficient (unless I'm missing something)

We can always review new PRs with additional refinements

Thanks again Nick for putting this together! 🙏

@bollwyvl
Copy link
Contributor Author

Here's what CI says: no further changes planned:

2024-02-26T23:34:26.7702074Z 
2024-02-26T23:38:23.8142191Z patching repodata:   0%|          | 0/9 [00:00<?, ?it/s]/home/conda/feedstock_root/build_artifacts/conda-forge-repodata-patches_1708990256258/work/gen_patch_json.py:953: DeprecationWarning: conda_build.index._apply_instructions is deprecated and will be removed in 24.5.0. Use `conda_index._apply_instructions` instead.
2024-02-26T23:38:23.8227669Z   new_repodata = _apply_instructions(subdir, repodata, instructions)
2024-02-26T23:38:25.9736682Z 
2024-02-26T23:38:25.9930935Z patching repodata:  11%|█         | 1/9 [03:59<31:53, 239.20s/it]
2024-02-26T23:38:25.9932547Z ================================================================================
2024-02-26T23:38:25.9934190Z ================================================================================
2024-02-26T23:38:25.9934763Z noarch
2024-02-26T23:38:25.9935447Z noarch::tpot-0.11.0-py_0.tar.bz2
2024-02-26T23:38:25.9935978Z -    "numpy >=1.16.3",
2024-02-26T23:38:25.9936547Z +    "numpy >=1.16.3,<1.20.0a0",
2024-02-26T23:38:25.9937015Z -    "python >=3.5",
2024-02-26T23:38:25.9937661Z -    "scikit-learn >=0.21.0",
2024-02-26T23:38:25.9938399Z +    "python >=3.5,<3.12.0a0",
2024-02-26T23:38:25.9938928Z +    "scikit-learn >=0.21.0,<0.22.0a0",
2024-02-26T23:38:25.9939830Z noarch::tpot-0.11.6.post2-pyhd3deb0d_1.tar.bz2
2024-02-26T23:38:25.9940412Z noarch::tpot-0.11.3-pyh9f0ad1d_0.tar.bz2
2024-02-26T23:38:25.9941107Z noarch::tpot-0.11.1-py_0.tar.bz2
2024-02-26T23:38:25.9941668Z noarch::tpot-0.11.7-pyhd8ed1ab_1.tar.bz2
2024-02-26T23:38:25.9942322Z noarch::tpot-0.11.6.post1-pyhd3deb0d_0.tar.bz2
2024-02-26T23:38:25.9942888Z noarch::tpot-0.11.5-pyh9f0ad1d_0.tar.bz2
2024-02-26T23:38:25.9943797Z noarch::tpot-0.11.2-pyh9f0ad1d_0.tar.bz2
2024-02-26T23:38:25.9944437Z noarch::tpot-0.11.6.post3-pyhd3deb0d_0.tar.bz2
2024-02-26T23:38:25.9945129Z noarch::tpot-0.11.6-pyh9f0ad1d_0.tar.bz2
2024-02-26T23:38:25.9945723Z -    "numpy >=1.16.3",
2024-02-26T23:38:25.9946161Z +    "numpy >=1.16.3,<1.20.0a0",
2024-02-26T23:38:25.9946717Z -    "python >=3.5",
2024-02-26T23:38:25.9947144Z +    "python >=3.5,<3.12.0a0",
2024-02-26T23:38:25.9947747Z noarch::tpot-0.12.1-pyhd8ed1ab_0.conda
2024-02-26T23:38:25.9948310Z noarch::tpot-0.12.0-pyhd8ed1ab_0.conda
2024-02-26T23:38:25.9948932Z -    "python >=3.5",
2024-02-26T23:38:25.9949367Z +    "python >=3.5,<3.12.0a0",
2024-02-26T23:38:25.9949767Z 
2024-02-26T23:38:27.2117814Z 
2024-02-26T23:38:27.2123155Z patching repodata:  22%|██▏       | 2/9 [04:00<11:34, 99.22s/it] 
2024-02-26T23:38:27.2123549Z ================================================================================
2024-02-26T23:38:27.2124069Z ================================================================================
2024-02-26T23:38:27.2124357Z linux-armv7l
2024-02-26T23:38:27.2124523Z 
2024-02-26T23:41:38.1263224Z 
2024-02-26T23:41:38.1271486Z patching repodata:  33%|███▎      | 3/9 [07:11<14:06, 141.09s/it]
2024-02-26T23:41:38.1277527Z ================================================================================
2024-02-26T23:41:38.1290121Z ================================================================================
2024-02-26T23:41:38.1291173Z linux-aarch64
2024-02-26T23:41:38.1291552Z 
2024-02-26T23:44:25.9407051Z 
2024-02-26T23:44:25.9410682Z patching repodata:  44%|████▍     | 4/9 [09:59<12:38, 151.64s/it]
2024-02-26T23:44:25.9411419Z ================================================================================
2024-02-26T23:44:25.9411998Z ================================================================================
2024-02-26T23:44:25.9412567Z linux-ppc64le
2024-02-26T23:44:25.9412893Z 
2024-02-26T23:44:36.3548564Z /home/conda/feedstock_root/build_artifacts/conda-forge-repodata-patches_1708990256258/work/gen_patch_json.py:953: DeprecationWarning: conda_build.index._apply_instructions is deprecated and will be removed in 24.5.0. Use `conda_index._apply_instructions` instead.
2024-02-26T23:44:36.3549890Z   new_repodata = _apply_instructions(subdir, repodata, instructions)
2024-02-26T23:44:45.7118326Z 
2024-02-26T23:44:45.7133291Z patching repodata:  56%|█████▌    | 5/9 [10:18<06:56, 104.09s/it]
2024-02-26T23:44:45.7133808Z ================================================================================
2024-02-26T23:44:45.7134096Z ================================================================================
2024-02-26T23:44:45.7134287Z linux-64
2024-02-26T23:44:45.7134367Z 
2024-02-26T23:47:12.5703244Z 
2024-02-26T23:47:12.5750710Z patching repodata:  67%|██████▋   | 6/9 [12:45<05:55, 118.63s/it]
2024-02-26T23:47:12.5753928Z ================================================================================
2024-02-26T23:47:12.5754365Z ================================================================================
2024-02-26T23:47:12.5755480Z osx-arm64
2024-02-26T23:47:12.5755742Z 
2024-02-26T23:47:41.3495665Z 
2024-02-26T23:47:42.3502206Z patching repodata:  78%|███████▊  | 7/9 [13:14<02:58, 89.11s/it] 
2024-02-26T23:47:42.3504082Z ================================================================================
2024-02-26T23:47:42.3504586Z ================================================================================
2024-02-26T23:47:42.3504953Z win-32
2024-02-26T23:47:42.3505082Z 
2024-02-26T23:53:24.1696469Z 
2024-02-26T23:53:24.1697913Z patching repodata:  89%|████████▉ | 8/9 [18:57<02:50, 170.02s/it]
2024-02-26T23:53:24.1698293Z ================================================================================
2024-02-26T23:53:24.1698601Z ================================================================================
2024-02-26T23:53:24.1698833Z osx-64
2024-02-26T23:53:24.1698922Z 
2024-02-26T23:54:14.3211806Z 
2024-02-26T23:54:14.3216026Z patching repodata: 100%|██████████| 9/9 [19:47<00:00, 132.55s/it]
2024-02-26T23:54:14.3217099Z ================================================================================
2024-02-26T23:54:14.3325137Z ================================================================================
2024-02-26T23:54:14.3325887Z win-64
2024-02-26T23:54:14.3326773Z 
2024-02-26T23:54:14.3327014Z 
2024-02-26T23:54:14.3327552Z patching repodata: 100%|██████████| 9/9 [19:47<00:00, 131.95s/it]

@jakirkham
Copy link
Member

This looks great Nick! Let's ship it :shipit:

@jakirkham jakirkham merged commit f421c38 into conda-forge:main Feb 27, 2024
4 checks passed
@charlesbluca charlesbluca mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tpot 0.12.1 doesn't work with python 3.12
2 participants
@bollwyvl @jakirkham