Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Information Prerequisites Section #1675

Closed
wants to merge 2 commits into from
Closed

Adding Information Prerequisites Section #1675

wants to merge 2 commits into from

Conversation

Radhika-Saini
Copy link

PR Checklist:

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@Radhika-Saini Radhika-Saini requested a review from a team as a code owner April 1, 2022 18:58
@Radhika-Saini Radhika-Saini deleted the outreachy-2022-Radhika-Saini branch April 1, 2022 19:00
@Radhika-Saini Radhika-Saini restored the outreachy-2022-Radhika-Saini branch April 1, 2022 19:00
@Radhika-Saini Radhika-Saini reopened this Apr 1, 2022
@Radhika-Saini Radhika-Saini changed the title Update README.md Adding Information Prerequisites Section Apr 1, 2022
@Radhika-Saini
Copy link
Author

I am Radhika Saini, an outreachy Applicant.
Work on my 1st issue #1346 and Requested PR.

Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, review complete! Let me know if you have any questions.


### Code of conduct

We adheres to the [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "adhere" instead of "adheres".


We adheres to the [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct).

1. Be kind to others. Do not insult or put down others. Behave professionally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire thing below is just a copy of NumFOCUS's code of conduct. It's good that you linked it and I'm sure conda-forge will have many of the same ideas, but it would probably be better if you didn't just copy them all word for word. I'll confer with Matt and then give you more guidance on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed coming back to this. Apologies. Turns out this is all fine. NumFocus has a template you can use for codes of conduct, I've learned. I'll finish the review now.


Thank you for helping make this a welcoming, friendly community for all.

This is the short version of Code of Conduct. If you want to read more about it check out on [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma needed between "it" and "check".

Also replace "on" after "check out" with "the".

"If you want to read more about it, check out the NumFOCUS Code of Conduct."


All reports will be kept confidential. Please go through it thoroughly [Reporting Guidelines](https://numfocus.org/code-of-conduct#reporting-guidelines).


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of unnecessary blank spaces here.

1. Whether this is an ongoing situation, or if there is a threat to anyone’s physical safety
2. What happened
3. Whether this event constitutes a code of conduct violation
4. Who the bad actor was, if any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a line between item 4 and the sentence on line 72.

9. Removing a person from our membership or other formal affiliation.
10. Publishing an account of the harassment and calling for the resignation of the alleged harasser from their responsibilities (usually pursued by people without formal authority: may be called for if the person is the event leader, or refuses to stand aside from the conflict of interest, or similar).
11. Any other response that we deem necessary and appropriate to the situation.
At NumFOCUS events, if a participant engages in behavior that violates this code of conduct, the conference organizers and staff may take any action they deem appropriate..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. A blank line needed between item 11 and the sentence below it.

9. Requiring that the person immediately leave the event and not return
10. Banning the person from future events (either indefinitely or for a certain time period)
11. Any other response that we deem necessary and appropriate to the situation
No one espousing views or values contrary to the standards of our code of conduct will be permitted to hold any position representing us, including volunteer positions. We have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned with this code of conduct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here as well. Blank line between item 11 and the paragraph below it.

_This code-of-conduct is common to the any projects of conda-forge found here(https://github.com/conda-forge)_

Our policy is to make sure that everyone aware of the initial incident is also made aware that official action has been taken, while still respecting the privacy of individuals. We may choose to make a public report of the incident, while maintaining the anonymity of those involved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank lines at the end of this file should be deleted.

@Radhika-Saini
Copy link
Author

Okays, Thanks for the review. Good to see Template, it helps and I will do the changes.

@Radhika-Saini Radhika-Saini deleted the outreachy-2022-Radhika-Saini branch April 9, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants