Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Information Prerequisites Code of Conduct #1703

Conversation

Radhika-Saini
Copy link

I made the changes in the Code of Conduct section.

@Radhika-Saini Radhika-Saini requested a review from a team as a code owner April 9, 2022 16:52
@Radhika-Saini
Copy link
Author

@ssurbhi560 @kathatherine @beckermr Kindly review.

Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Review done. For future reference, you don't need to close your PRs after being given a review. Please just make the changes and push the new commit to the same branch. Your changes will show up in the PR.

src/README.md Outdated
@@ -1,4 +1,4 @@
The docs are built on GitHub Actions and run the ``.ci_scripts/update_docs`` script.
## The docs are built on GitHub Actions and run the ``.ci_scripts/update_docs`` script.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have header formatting.

src/README.md Outdated

# Code of conduct

The [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct) is followed by us.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "The NumFOCUS Code of Conduct is followed by us." maybe write "Conda-forge follows the NumFOCUS Code of Conduct."

src/README.md Outdated

The [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct) is followed by us.

1.Be considerate of others. Don't make others feel bad by insulting or dismissing them. Behave in a professional manner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of these numbers should have a space after it.


We will make every effort to ensure your safety and assist you with any immediate requirements, especially if you are attending an in-person event. We'll do everything we can to acknowledge receipt within 24 hours (and we'll aim for much faster). Take a look at the [What Happens After a Report is Filed?](https://numfocus.org/code-of-conduct#enforcement) process.

## Examining the Document
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure each header has a blank line after it.

@Radhika-Saini
Copy link
Author

@kathatherine Thanks for the feedback.
I made the changes. Kindly review commit-2.

Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one change and you should be good!

src/README.md Outdated

# Code of conduct

Conda-forge follows the NumFOCUS Code of Conduct-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a colon (:) instead of a hyphen (-), please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kathatherine, Done in Commit 3.

Copy link
Contributor

@kathatherine kathatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@jaimergp
Copy link
Member

Superseded by #1640

@jaimergp jaimergp closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants