-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Information Prerequisites Code of Conduct #1703
Adding Information Prerequisites Code of Conduct #1703
Conversation
@ssurbhi560 @kathatherine @beckermr Kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Review done. For future reference, you don't need to close your PRs after being given a review. Please just make the changes and push the new commit to the same branch. Your changes will show up in the PR.
src/README.md
Outdated
@@ -1,4 +1,4 @@ | |||
The docs are built on GitHub Actions and run the ``.ci_scripts/update_docs`` script. | |||
## The docs are built on GitHub Actions and run the ``.ci_scripts/update_docs`` script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not have header formatting.
src/README.md
Outdated
|
||
# Code of conduct | ||
|
||
The [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct) is followed by us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "The NumFOCUS Code of Conduct is followed by us." maybe write "Conda-forge follows the NumFOCUS Code of Conduct."
src/README.md
Outdated
|
||
The [NumFOCUS Code of Conduct](https://numfocus.org/code-of-conduct) is followed by us. | ||
|
||
1.Be considerate of others. Don't make others feel bad by insulting or dismissing them. Behave in a professional manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each of these numbers should have a space after it.
|
||
We will make every effort to ensure your safety and assist you with any immediate requirements, especially if you are attending an in-person event. We'll do everything we can to acknowledge receipt within 24 hours (and we'll aim for much faster). Take a look at the [What Happens After a Report is Filed?](https://numfocus.org/code-of-conduct#enforcement) process. | ||
|
||
## Examining the Document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure each header has a blank line after it.
@kathatherine Thanks for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just that one change and you should be good!
src/README.md
Outdated
|
||
# Code of conduct | ||
|
||
Conda-forge follows the NumFOCUS Code of Conduct- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a colon (:) instead of a hyphen (-), please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kathatherine, Done in Commit 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Superseded by #1640 |
I made the changes in the Code of Conduct section.