Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status page: Add descendants count, sort alphabetically #2176

Merged
merged 6 commits into from
May 8, 2024

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented May 7, 2024

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

Addressing #2137 (comment)

cc @h-vetinari

@jaimergp jaimergp requested a review from a team as a code owner May 7, 2024 17:23
Copy link

netlify bot commented May 7, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit bcde9c5
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/663b1ebb542b7c000857ace3
😎 Deploy Preview https://deploy-preview-2176--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaimergp jaimergp mentioned this pull request May 7, 2024
16 tasks
@jaimergp
Copy link
Member Author

jaimergp commented May 7, 2024

Ah wait, reading #2090 (comment), I think this needs to know the total number, not just the children.

Any tips @afshin?

@jaimergp
Copy link
Member Author

jaimergp commented May 7, 2024

nvm it was there right in the json payload

@jaimergp jaimergp changed the title Status page: Add children count, sort alphabetically Status page: Add descendants count, sort alphabetically May 7, 2024
@@ -219,6 +222,7 @@ function Table({ details }) {
<tr>
<th style={{ width: 200 }}>Name</th>
<th style={{ width: 115 }}>PRs made</th>
<th style={{ width: 115 }}>Descendants</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "Number of Descendants" or something? It is clearly a number but IDK in terms of things being accessible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we should use the same name twice (c.f. "immediate children") - either children or descendants, but not both. I mean yes, in a strictly genealogical sense the distinction makes sense, but I think it ends up being more confusing to call the same concept by two different names.

So perhaps "Total number of children" / "Immediate children"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dependent feedstocks" is the most precise term I can think of for this. It is wordy though. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to save some space in the headers but yea, let me know which ones you prefer and we'll get that in. If we go for verbose, I'd pick "Total number of children" / "Immediate children".

@h-vetinari
Copy link
Member

Thanks a lot @jaimergp for tackling this, this already looks very promising!

Could we sort by (descendants DESC, name ASC)? That's mostly how the previous status page worked, i.e. grouping the packages with the most descendants at the top.

It would be amazing if one could sort the table by a given column when clicking on the header, but I imagine that's a whole 'nother level of complexity so I'm not asking for that here.

@jaimergp
Copy link
Member Author

jaimergp commented May 8, 2024

It would be amazing if one could sort the table by a given column when clicking on the header, but I imagine that's a whole 'nother level of complexity so I'm not asking for that here.

I briefly looked into it by trying to bring the logic from the overview table, but it was a bit trickier than expected. I'll add it to the meta issue todo list.

Could we sort by (descendants DESC, name ASC)?

I implemented this sort now:

  1. Total children DESC
  2. Status as in ORDERED (i.e. as in the progress bar)
  3. Name ASC

This way you can see the biggest chunks first, but you can still filter unwanted statuses out with the buttons above. Otherwise, you'd have to scroll the whole table for all statuses just to parse which ones are the biggest.

@beckermr beckermr merged commit 98be6dc into conda-forge:main May 8, 2024
6 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@h-vetinari
Copy link
Member

Thanks @jaimergp, this looks great and is really really helpful! 🙏

@h-vetinari
Copy link
Member

I implemented this sort now:

Need to emphasise again what a huge improvement this is. Being able to sort all outstanding statuses by total children (rather than having to cross-reference between different status sections) is amazing! 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants