-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status page: Add descendants count, sort alphabetically #2176
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ah wait, reading #2090 (comment), I think this needs to know the total number, not just the children. Any tips @afshin? |
nvm it was there right in the json payload |
@@ -219,6 +222,7 @@ function Table({ details }) { | |||
<tr> | |||
<th style={{ width: 200 }}>Name</th> | |||
<th style={{ width: 115 }}>PRs made</th> | |||
<th style={{ width: 115 }}>Descendants</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "Number of Descendants" or something? It is clearly a number but IDK in terms of things being accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think we should use the same name twice (c.f. "immediate children") - either children or descendants, but not both. I mean yes, in a strictly genealogical sense the distinction makes sense, but I think it ends up being more confusing to call the same concept by two different names.
So perhaps "Total number of children" / "Immediate children"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dependent feedstocks" is the most precise term I can think of for this. It is wordy though. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to save some space in the headers but yea, let me know which ones you prefer and we'll get that in. If we go for verbose, I'd pick "Total number of children" / "Immediate children"
.
Thanks a lot @jaimergp for tackling this, this already looks very promising! Could we sort by It would be amazing if one could sort the table by a given column when clicking on the header, but I imagine that's a whole 'nother level of complexity so I'm not asking for that here. |
I briefly looked into it by trying to bring the logic from the overview table, but it was a bit trickier than expected. I'll add it to the meta issue todo list.
I implemented this sort now:
This way you can see the biggest chunks first, but you can still filter unwanted statuses out with the buttons above. Otherwise, you'd have to scroll the whole table for all statuses just to parse which ones are the biggest. |
Thanks all! 🙏 |
Thanks @jaimergp, this looks great and is really really helpful! 🙏 |
Need to emphasise again what a huge improvement this is. Being able to sort all outstanding statuses by total children (rather than having to cross-reference between different status sections) is amazing! 🤩 |
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
fileAddressing #2137 (comment)
cc @h-vetinari