-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the rendering of markdown text between backsticks in the incidents titles #2229
Fix the rendering of markdown text between backsticks in the incidents titles #2229
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
15db936
to
8f07439
Compare
b6692e1
to
f6eca20
Compare
Thanks @HaudinFlorence. Is there a chance we can use that component to also render the plain URLs into clickable ones? i.e. #2181 |
@jaimergp I think it can be used but I am not sure how since it seems if I see correctly that Github urls are only given as simple text in |
Since we are using See this example from import React from 'react'
import {createRoot} from 'react-dom/client'
import Markdown from 'react-markdown'
import remarkGfm from 'remark-gfm'
const markdown = `Just a link: www.nasa.gov.`
createRoot(document.body).render(
<Markdown remarkPlugins={[remarkGfm]}>{markdown}</Markdown>
) |
Thanks for the pointer. It works. I will open a specific PR to fix issue #2181 |
@jaimergp I don't know how to fix the check link failing test. If you have any hint please? Thanks. |
We will need to either ignore link checks in anaconda.org/conda-forge or increase the timeouts, but don't worry for now. |
Added #2231 |
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
fileThis PR aimed at fixing task 5 of issue #2137 mentioning that in incidents titles, the text elements between backsticks were not rendered in markdown style.