Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change migration table to only have one header for the 3 types of migrations #2248

Merged

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Jul 30, 2024

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

This PR aims at fixing task 11 of issue #2137
Its objective is to modify the migration table in order to have only one header for the three type of migrations Long-running, Regular and Closed. In this way, we avoid the previous repetition of the row with mention of Name and the different categories PRs made, Done, In PR, Awaiting PRs, Awaiting parents, Not solvable, Bot error.
The rendering of the PR is the following.
Screencast from 30-07-2024 17:59:45.webm

Before
Screenshot from 2024-07-30 18-03-40

Now
Screenshot from 2024-07-30 18-01-36

@HaudinFlorence HaudinFlorence requested a review from a team as a code owner July 30, 2024 15:58
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit e7323d7
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/66a93dcdec85070008fb0e4e
😎 Deploy Preview https://deploy-preview-2248--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HaudinFlorence
Copy link
Contributor Author

pre-commit.ci autofix

@beckermr beckermr merged commit 02b11bd into conda-forge:main Jul 31, 2024
6 checks passed
@jakirkham
Copy link
Member

It looks like the column headings are changing width when expanding fields migrators (please see screenshots). Is there a way to set some fixed column width in advance?

Screenshot 2024-07-30 at 6 08 04 PM Screenshot 2024-07-30 at 6 08 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants