-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for pytorch 2.5, add python 3.13, update to flash-attn 2.7.0.post2 #20
Rebuild for pytorch 2.5, add python 3.13, update to flash-attn 2.7.0.post2 #20
Conversation
…nda-forge-pinning 2024.10.08.15.30.26
…nda-forge-pinning 2024.11.04.16.29.58
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@weiji14 I was able to build for linux with no errors (https://anaconda.org/jslee02/flash-attn/files). Could you please retrigger the CI to see if this build? |
Sure, I can restart the CI, but didn't want to use up most of the Openstack CI runners if you're still working on #19 (they have a limited amount of runners, and these flash-attn builds take ~9 hours as you're aware). Would it be possible to finish #19 first and then we do Pytorch 2.5 rebuild + Python 3.13 (#17)? |
Oh sorry, I was confusing you with the author of #19 (been looking at too many feedstocks recently 😅). This feedstock is a little different to the other conda-forge feedstocks in that 1) We're using a separate Openstack CI system that has a limited amount of resources compared to Azure Pipelines, and 2) The CI takes almost 9 hours to build per combination, and with 5 Python versions * 2 CUDA versions = 10 runs, this can block up the server queue (as mentioned before at #10 (comment)). So I think we'll wait for #19 to finish first, will be easier to rebase this one (#20) on top of that later. |
No worries! The plan makes sense to me, and it sounds good. In the meantime, I've pushed my local build for pytorch 2.5, so if someone wants to try flash-attn with pytorch 2.5, they can give it a shot! |
…nda-forge-pinning 2024.11.17.06.32.00
We will merge the other pending branches into this branch for the next release. |
Waiting for #19 to complete in order to publish rebase because I don't want to monopolize the build resources. I already have it rebased locally. |
No automerge because the bot doesn't have permission to trigger builds. Anyone please merge if everything passes. |
Cherry-picked from 3f3a845. Need to use 2.7.0.post2 because 2.7.0 is not on PyPI, see https://pypi.org/project/flash-attn/2.7.0.post2/
There was a download error because the 2.7.0 release wasn't on PyPI, so I've bumped it to 2.7.0.post2 (https://pypi.org/project/flash-attn/2.7.0.post2/). I've also checked the diff on |
All builds passed except for Python 3.13 + CUDA 11.8 which seemed to have hit a timeout error:
Do we want to restart that build to make sure it works? I've tested building locally up to the [1/85] step, but unsure if it'll get to [85/85] 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just approve and merge, assuming that the timeout at #20 (comment) is harmless 🤞
We don't need to use |
Yeah, but we're pulling from PyPI, and 2.7.0 wasn't published to PyPI (see https://pypi.org/project/flash-attn/2.7.0.post2/#history). We would have needed to hardcode flash-attn-feedstock/recipe/meta.yaml Lines 1 to 8 in 82abb88
|
This PR has been triggered in an effort to update pytorch25.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11669226258 - please use this URL for debugging.
Closes #22
Closes #17