Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on windows #183

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

zklaus
Copy link

@zklaus zklaus commented Jul 20, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #182.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Author

zklaus commented Jul 20, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libnetcdf-feedstock/actions/runs/5611177105.

@djhoese
Copy link
Contributor

djhoese commented Jul 20, 2023

Build didn't hang, but I also don't see xarray or "test_netcdf" in the log at all.

@zklaus
Copy link
Author

zklaus commented Jul 20, 2023

Yeah. I'll try to add a run_test.bat.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/run_test.bat Outdated Show resolved Hide resolved
Co-authored-by: Xylar Asay-Davis <[email protected]>
@zklaus
Copy link
Author

zklaus commented Jul 20, 2023

Incidentally, I did find this

For this reason, h5py is advertised for EITHER multithreaded use OR use alongside PyTables/NetCDF4, but not both at the same time.

@xylar
Copy link
Contributor

xylar commented Jul 20, 2023

It seems like windows is still not running tests @ocefpaf or anyone else, any insight into why that could be happening?

recipe/meta.yaml Outdated Show resolved Hide resolved
@djhoese
Copy link
Contributor

djhoese commented Jul 20, 2023

FYI I'm working on a C-only example, but its been a while compiling C, not to mention never having done it in Windows, in a conda-forge environment, with the NetCDF library.

@zklaus
Copy link
Author

zklaus commented Jul 20, 2023

Hmmpf. It just does not want to run the tests. Unless it does and we just don't see it.

@xylar
Copy link
Contributor

xylar commented Jul 20, 2023

Hmmpf. It just does not want to run the tests. Unless it does and we just don't see it.

I don't see any evidence it's even creating the test environment, which is really odd. It's almost like it think it's cross-compiling or something and it just skips testing.

@djhoese
Copy link
Contributor

djhoese commented Jul 20, 2023

#include <netcdf.h>
#include <stdio.h>


int main() {
    int res, ncid;
    res = nc_create("test_netcdf_c.nc", NC_CLOBBER, &ncid);
    if (res) {
        printf("FAILURE!\n");
        return res;
    }
    printf("SUCCESS!\n");
    return 0;
}

But...I have no idea how to successfully compile it in Windows. No matter what I do it tells me that nc_create isn't defined. So that means I also have no idea if it causes things to hang.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 20, 2023

@isuruf we are failing to get the Windows test o run here (or maybe we are not seeing the failures?). We could use your help. Our CIs setup became so complex lately that is quite hard to figure out what is going on under all these layers.

@isuruf
Copy link
Member

isuruf commented Jul 20, 2023

Sorry about that. conda-forge/conda-forge-ci-setup-feedstock#256 should fix it.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 20, 2023

Sorry about that. conda-forge/conda-forge-ci-setup-feedstock#256 should fix it.

Phew! I thought we were going crazy here 😄

@zklaus

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@zklaus

This comment was marked as outdated.

@zklaus

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@zklaus

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent builds cause hanging on Windows
5 participants